After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 752818 - qtdemux: add support for XML timed-text subtitles
qtdemux: add support for XML timed-text subtitles
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal enhancement
: 1.7.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on: 747774
Blocks:
 
 
Reported: 2015-07-24 10:31 UTC by Chris Bass
Modified: 2015-09-25 22:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add support for XML timed-text subtitles (2.30 KB, patch)
2015-07-24 10:31 UTC, Chris Bass
none Details | Review
Add support for XML timed-text subtitles (1.93 KB, patch)
2015-08-18 13:39 UTC, Chris Bass
committed Details | Review

Description Chris Bass 2015-07-24 10:31:31 UTC
Created attachment 308070 [details] [review]
Add support for XML timed-text subtitles

XML timed-text subtitles are encapsulated in ISO BMFF files using the stpp sample entry type. The attached patch handles this sample entry, setting the caps of the subtitle src pad to be "application/ttml+xml". It also adds the caps "application/x-mp4-text" to the list of accepted sink pad caps, to match that used in the dashdemux patch added to https://bugzilla.gnome.org/show_bug.cgi?id=747774
Comment 1 Sebastian Dröge (slomo) 2015-08-18 09:25:35 UTC
Comment on attachment 308070 [details] [review]
Add support for XML timed-text subtitles

Caps name discussion in the other bug.


sthd is not used anywhere in your patch, should it?
Comment 2 Chris Bass 2015-08-18 13:38:13 UTC
(In reply to Sebastian Dröge (slomo) from comment #1)
[...] 
> sthd is not used anywhere in your patch, should it?

I'd added it in initially because the sthd (Subtitle Media Header) box was defined in an amendment to the ISO BMFF spec, but it turns out that the box doesn't carry any information. I'll remove it from the patch...
Comment 3 Chris Bass 2015-08-18 13:39:06 UTC
Created attachment 309472 [details] [review]
Add support for XML timed-text subtitles

Updated patch, as per comments.
Comment 4 Sebastian Dröge (slomo) 2015-08-19 07:33:02 UTC
Comment on attachment 309472 [details] [review]
Add support for XML timed-text subtitles

Looks good to me, thanks. Do you also have an element that actually handles these subtitles and can render them?
Comment 5 Chris Bass 2015-08-19 07:41:23 UTC
(In reply to Sebastian Dröge (slomo) from comment #4)
> Comment on attachment 309472 [details] [review] [review]
> Add support for XML timed-text subtitles
> 
> Looks good to me, thanks. Do you also have an element that actually handles
> these subtitles and can render them?

Yes, I have an extended version of subparse that parses them, and a modified version of textoverlay that renders them. I'm currently getting the code ready to share - should hopefully be available soon.
Comment 6 Sebastian Dröge (slomo) 2015-09-25 22:52:12 UTC
commit 563ffc0d8ff426a6691051e289a6beec3e20abdf
Author: Chris Bass <floobleflam@gmail.com>
Date:   Tue Aug 18 14:30:57 2015 +0100

    qtdemux: support timed-text subtitle tracks.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=752818