After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 752669 - rtpsession: Expose RTPSource stats through stats property
rtpsession: Expose RTPSource stats through stats property
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal enhancement
: 1.7.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-07-21 13:32 UTC by Håvard Graff (hgr)
Modified: 2015-10-11 09:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
in patch form (4.52 KB, patch)
2015-09-24 08:45 UTC, Håvard Graff (hgr)
needs-work Details | Review
rtpmanager: Add 'source-stats' to stats and notify (4.34 KB, patch)
2015-09-25 06:03 UTC, Stian Selnes (stianse)
none Details | Review
rtpmanager: Add 'source-stats' to stats and notify (4.34 KB, patch)
2015-09-25 06:08 UTC, Stian Selnes (stianse)
none Details | Review
rtpmanager: Add 'source-stats' to stats and notify (4.33 KB, patch)
2015-10-06 07:50 UTC, Stian Selnes (stianse)
committed Details | Review

Description Håvard Graff (hgr) 2015-07-21 13:32:39 UTC
We did it using a GValueArray for each GstStructure with RTPSource stats, to make it more python-binding friendly.

https://github.com/pexip/gst-plugins-good/commit/e66a7a641c1b54146e5ac56228d66f934ab48355.patch
Comment 1 Håvard Graff (hgr) 2015-09-24 08:45:15 UTC
Created attachment 312011 [details] [review]
in patch form
Comment 2 Sebastian Dröge (slomo) 2015-09-24 08:53:31 UTC
Review of attachment 312011 [details] [review]:

Looks good except for cosmetic changes

::: gst/rtpmanager/gstrtpsession.c
@@ +674,2 @@
    *
+   * Since: 1.6

The "Since: 1.6" should only be at the "source-stats" field

::: gst/rtpmanager/rtpsession.c
@@ +497,2 @@
    *
+   * Since: 1.6

Same here
Comment 3 Stian Selnes (stianse) 2015-09-25 06:03:31 UTC
Created attachment 312111 [details] [review]
rtpmanager: Add 'source-stats' to stats and notify

Add statitics from each rtp source to the rtp session property.
'source-stats' is a GValueArray where each element is a GstStructure of
stats for one rtp source.

The availability of new stats is signaled via g_object_notify.
Comment 4 Stian Selnes (stianse) 2015-09-25 06:08:09 UTC
Created attachment 312112 [details] [review]
rtpmanager: Add 'source-stats' to stats and notify

Add statitics from each rtp source to the rtp session property.
'source-stats' is a GValueArray where each element is a GstStructure of
stats for one rtp source.

The availability of new stats is signaled via g_object_notify.
Comment 5 Sebastian Dröge (slomo) 2015-09-25 07:54:57 UTC
Review of attachment 312112 [details] [review]:

Thanks :)
Comment 6 Sebastian Dröge (slomo) 2015-10-02 14:33:51 UTC
Comment on attachment 312112 [details] [review]
rtpmanager: Add 'source-stats' to stats and notify

Does not apply anymore, please rebase :) And make it "Since: 1.8", not 1.6.
Comment 7 Stian Selnes (stianse) 2015-10-06 07:50:03 UTC
Created attachment 312712 [details] [review]
rtpmanager: Add 'source-stats' to stats and notify

Add statitics from each rtp source to the rtp session property.
'source-stats' is a GValueArray where each element is a GstStructure of
stats for one rtp source.

The availability of new stats is signaled via g_object_notify.
Comment 8 Sebastian Dröge (slomo) 2015-10-11 09:57:35 UTC
Comment on attachment 312712 [details] [review]
rtpmanager: Add 'source-stats' to stats and notify

commit 91a78053c73baf4e34507f73715b725e3a6167b3
Author: Stian Selnes <stian@pexip.com>
Date:   Tue Jul 14 15:19:44 2015 +0200

    rtpmanager: Add 'source-stats' to stats and notify
    
    Add statitics from each rtp source to the rtp session property.
    'source-stats' is a GValueArray where each element is a GstStructure of
    stats for one rtp source.
    
    The availability of new stats is signaled via g_object_notify.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=752669