After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 752568 - Vertical Gtk::LevelBar not via C++
Vertical Gtk::LevelBar not via C++
Status: RESOLVED FIXED
Product: gtkmm
Classification: Bindings
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtkmm-forge
gtkmm-forge
Depends on:
Blocks:
 
 
Reported: 2015-07-18 14:48 UTC by Tobias Hoffmann
Modified: 2015-09-14 21:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Tobias Hoffmann 2015-07-18 14:48:08 UTC 
The C++ wrapper Gtk::LevelBar does not provide the Gtk::Orientable interface, although in C GtkLevelBar implements GtkOrientable:
  gtk_orientable_set_orientation(GTK_ORIENTABLE(mybar.gobj()),GTK_ORIENTATION_VERTICAL);

Please provide a pure C++ solution.
Comment 1 Murray Cumming 2015-07-18 19:55:08 UTC 
Thanks. Yes, that was my fault back in 2012 when I added Gtk::LevelBar to gtkmm. However, we cannot now add a base class (Gtk::Orientable) to LevelBar without breaking ABI.

In the meantime, I have added some documentation about this:
https://git.gnome.org/browse/gtkmm/commit/?id=f3229bc34d9a4bbbbff2000302032e1c9227ffe3

The TODO there will make sure that we add this base class when we can break ABI (for a future GTK+ 4, for instance) so I'll close this bug knowing that it won't be forgotten.
Comment 2 Tobias Hoffmann 2015-07-19 10:00:46 UTC 
Hmm, I see. 
If we currently cannot derive from Gtk::Orientable, we could at least add (a copy of) the most important method of Gtk::Orientable, namely void set_orientation(Gtk::Orientation), to Gtk::LevelBar as a stopgap measure?
Comment 3 Murray Cumming 2015-09-14 21:22:44 UTC 
Yes, that seems like a good idea. I've added that in this commit:
https://git.gnome.org/browse/gtkmm/commit/?id=a985e6125a86336c63aa7889f6d4b40c9d26cd65

Thanks.