After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 751048 - avfvideosrc: caps should indicate frame rate range
avfvideosrc: caps should indicate frame rate range
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Mac OS
: Normal normal
: 1.5.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-06-16 14:22 UTC by Ilya Konstantinov
Modified: 2015-06-22 16:23 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
avfvideosrc: add frame rate range to caps (6.24 KB, patch)
2015-06-16 14:34 UTC, Ilya Konstantinov
none Details | Review
avfvideosrc: add frame rate range to caps (4.75 KB, patch)
2015-06-18 08:45 UTC, Ilya Konstantinov
committed Details | Review
(REFACTOR) avfvideosrc:add frame rate range to caps (4.88 KB, patch)
2015-06-18 08:50 UTC, Ilya Konstantinov
rejected Details | Review

Description Ilya Konstantinov 2015-06-16 14:22:33 UTC
AVFoundation reports both minimum and maximum frame rate in its formats. We should indicate the frame rate range in caps, rather than just maximum frame rate (as we currently do).
Comment 1 Ilya Konstantinov 2015-06-16 14:34:41 UTC
Created attachment 305403 [details] [review]
avfvideosrc: add frame rate range to caps
Comment 2 Ilya Konstantinov 2015-06-17 17:33:26 UTC
Comment on attachment 305403 [details] [review]
avfvideosrc: add frame rate range to caps

Please don't commit yet -- this fixes behavior on iOS (where there are FPS ranges) but breaks OS X (where ranges are (25-25), (30-30) etc.). I'll come up with a better patch.
Comment 3 Ilya Konstantinov 2015-06-18 08:45:05 UTC
Created attachment 305522 [details] [review]
avfvideosrc: add frame rate range to caps

Only use GST_AVF_FPS_RANGE_CAPS_NEW when it's an actual range.
Comment 4 Ilya Konstantinov 2015-06-18 08:50:56 UTC
Created attachment 305523 [details] [review]
(REFACTOR) avfvideosrc:add frame rate range to caps

Slightly refactored version of attachment 305522 [details] [review]:

- use gst_caps_copy for the RGBA GLMemory variant

If you think it's nicer/clearer, commit this patch instead.
Comment 5 Sebastian Dröge (slomo) 2015-06-22 16:23:27 UTC
commit 58ce6d50a0eaa218c4fc7b7aaeb32f45e5b0b0da
Author: Ilya Konstantinov <ilya.konstantinov@gmail.com>
Date:   Tue Jun 16 17:18:52 2015 +0300

    avfvideosrc: add frame rate range to caps
    
    When AVFoundation indicates a supported frame rate range, add it to
    the caps. This is important for devices such as the iPhone 6, which
    indicate a single AVFrameRateRange of 2fps - 60fps.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=751048