After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 750691 - playsink: fix the channel of color balance element
playsink: fix the channel of color balance element
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other All
: Normal normal
: 1.5.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-06-10 10:28 UTC by Víctor Manuel Jáquez Leal
Modified: 2015-06-10 11:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
playsink: fix the channel of color balance element (1.33 KB, patch)
2015-06-10 10:28 UTC, Víctor Manuel Jáquez Leal
committed Details | Review

Description Víctor Manuel Jáquez Leal 2015-06-10 10:28:29 UTC
The mapping of the playsink proxy channel to the color balance element channel
is wrong, because the proxy channel is usede instead  of color balance element
channel.
Comment 1 Víctor Manuel Jáquez Leal 2015-06-10 10:28:34 UTC
Created attachment 304936 [details] [review]
playsink: fix the channel of color balance element

When traversing the color balance element channel list to find the one that
matches with the playsink proxy, the assignation was set to iterator of the
playsink proxy, not the balance element. Thus, the mapping to the values of
the balance element channel was wrong.

This patch fixes the assignation of the color balance element channel, so the
mapping to the channel of the color balance element is fixed.
Comment 2 Sebastian Dröge (slomo) 2015-06-10 11:12:43 UTC
Comment on attachment 304936 [details] [review]
playsink: fix the channel of color balance element

Thanks :)
Comment 3 Sebastian Dröge (slomo) 2015-06-10 11:12:57 UTC
commit 7b78a33dc61e3ba33cfe0a39c548269d798d7fa5
Author: Víctor Manuel Jáquez Leal <vjaquez@igalia.com>
Date:   Wed Jun 10 12:26:38 2015 +0200

    playsink: fix the channel of color balance element
    
    When traversing the color balance element channel list to find the one that
    matches with the playsink proxy, the assignation was set to iterator of the
    playsink proxy, not the balance element. Thus, the mapping to the values of
    the balance element channel was wrong.
    
    This patch fixes the assignation of the color balance element channel, so the
    mapping to the channel of the color balance element is fixed.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=750691