Created attachment 304686 [details] [review]
[PATCH] build: Fix the wrong variable name

Review of attachment 304686 [details] [review]:

Thanks for the patch! Could you please add "Fall out from 2a07dc2854eebc6721d5ec99d4df2ab587143e10" in the commit message?

::: src/daemon/goadaemon.c
@@ +633,3 @@
       g_signal_handlers_disconnect_by_func (goa_object_peek_account (object),
                                             G_CALLBACK (on_account_handle_remove),
+                                            self);

Good catch. I wonder how I managed to sneak this in past Continuous. :/ Embarassing.

Created attachment 304732 [details] [review]
[PATCH] build: Fix the wrong variable name

(In reply to Debarshi Ray from comment #2)
> Review of attachment 304686 [details] [review] [review]:
> 
> Thanks for the patch! Could you please add "Fall out from
> 2a07dc2854eebc6721d5ec99d4df2ab587143e10" in the commit message?
> 
> ::: src/daemon/goadaemon.c
> @@ +633,3 @@
>        g_signal_handlers_disconnect_by_func (goa_object_peek_account
> (object),
>                                              G_CALLBACK
> (on_account_handle_remove),
> +                                            self);
> 
> Good catch. I wonder how I managed to sneak this in past Continuous. :/
> Embarassing.

I think this problem was not found on GNU/Linux because glibc does have a function called 'daemon'.

Review of attachment 304732 [details] [review]:

Perfect. Can you also push it to the gnome-3-16 branch?

(In reply to Ting-Wei Lan from comment #3) 
> I think this problem was not found on GNU/Linux because glibc does have a
> function called 'daemon'.

Right. Makes sense.

Attachment 304732 [details] pushed to master as ba3a205 - build: Fix the wrong variable name
Attachment 304732 [details] pushed to gnome-3-16 as fb854bf - build: Fix the wrong variable name