After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 750471 - rtspsrc: Add support for TLS client authentication
rtspsrc: Add support for TLS client authentication
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other Linux
: Normal enhancement
: 1.5.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-06-06 01:59 UTC by Xavier Claessens
Modified: 2015-06-10 00:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
GstRTSPConnection: Add GTlsInteraction support (4.94 KB, patch)
2015-06-07 00:57 UTC, Xavier Claessens
committed Details | Review
rtspsrc: Add a GTlsInteraction property (4.34 KB, patch)
2015-06-07 01:11 UTC, Xavier Claessens
none Details | Review
GstRTSPAuth: Add client certificate authentication support (6.32 KB, patch)
2015-06-07 01:11 UTC, Xavier Claessens
none Details | Review
GstRTSPAuth: Add client certificate authentication support (8.80 KB, patch)
2015-06-09 22:21 UTC, Xavier Claessens
committed Details | Review
rtspsrc: Add a GTlsInteraction property (4.23 KB, patch)
2015-06-10 00:02 UTC, Xavier Claessens
committed Details | Review

Description Xavier Claessens 2015-06-06 01:59:01 UTC
GstRTSPSrc should have a GTlsInteraction property to send a certificate to server.
Comment 1 Tim-Philipp Müller 2015-06-06 11:05:27 UTC
Did you mean to attach a patch?
Comment 2 Xavier Claessens 2015-06-06 11:48:04 UTC
Yes, finishing the corresponding patch on gst-rtsp-server for testing together first.
Comment 3 Xavier Claessens 2015-06-07 00:57:30 UTC
Created attachment 304718 [details] [review]
GstRTSPConnection: Add GTlsInteraction support
Comment 4 Xavier Claessens 2015-06-07 01:11:07 UTC
Created attachment 304719 [details] [review]
rtspsrc: Add a GTlsInteraction property

It can be used for TLS client authentication.
Comment 5 Xavier Claessens 2015-06-07 01:11:58 UTC
Created attachment 304720 [details] [review]
GstRTSPAuth: Add client certificate authentication support
Comment 6 Xavier Claessens 2015-06-07 01:19:52 UTC
Note that for this to be useful you need to pass a GTlsInteraction subclass that implement request_certificate() which has been added in glib 2.40. But it afaik it still build fine even with gst's current glib 2.32.
Comment 7 Olivier Crête 2015-06-08 18:49:20 UTC
Review of attachment 304720 [details] [review]:

::: gst/rtsp-server/rtsp-auth.c
@@ +570,3 @@
+
+  g_signal_connect (tls, "accept-certificate",
+      G_CALLBACK (accept_certificate_cb), auth);

I think you should instead add a "accept-certificate" signal on the GstRTSPAuth object. This implementation does nothing, as it is the default behavior.
Comment 8 Xavier Claessens 2015-06-09 22:21:51 UTC
Created attachment 304903 [details] [review]
GstRTSPAuth: Add client certificate authentication support
Comment 9 Xavier Claessens 2015-06-10 00:02:22 UTC
Created attachment 304906 [details] [review]
rtspsrc: Add a GTlsInteraction property

It can be used for TLS client authentication.
Comment 10 Olivier Crête 2015-06-10 00:07:20 UTC
Comment on attachment 304718 [details] [review]
GstRTSPConnection: Add GTlsInteraction support

Committed to gst-p-base

commit 74a434761403fbc491af7b564dcb102c81815888
Author: Xavier Claessens <xavier.claessens@collabora.com>
Date:   Fri Jun 5 22:04:24 2015 -0400

    GstRTSPConnection: Add GTlsInteraction support
    
    https://bugzilla.gnome.org/show_bug.cgi?id=750471
Comment 11 Olivier Crête 2015-06-10 00:08:06 UTC
Comment on attachment 304906 [details] [review]
rtspsrc: Add a GTlsInteraction property

Committed to gst-p-good:
commit b0b3e8e2cc5820851ed9b2c785ba4f0b47f73a2c
Author: Xavier Claessens <xavier.claessens@collabora.com>
Date:   Sat Jun 6 21:09:19 2015 -0400

    rtspsrc: Add a GTlsInteraction property
    
    It can be used for TLS client authentication.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=750471
Comment 12 Olivier Crête 2015-06-10 00:08:34 UTC
Comment on attachment 304903 [details] [review]
GstRTSPAuth: Add client certificate authentication support

Commited ot gst-rtsp-server:

commit 6ec8fe44b2da3b61f8b2e0132eeb3a3f81cd7c95
Author: Xavier Claessens <xavier.claessens@collabora.com>
Date:   Fri Jun 5 22:35:39 2015 -0400

    GstRTSPAuth: Add client certificate authentication support
    
    https://bugzilla.gnome.org/show_bug.cgi?id=750471