After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 749666 - allow git blame directly on lines
allow git blame directly on lines
Status: RESOLVED OBSOLETE
Product: gnome-builder
Classification: Other
Component: editor
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-05-21 08:19 UTC by Lasse Schuirmann
Modified: 2018-01-11 09:49 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Lasse Schuirmann 2015-05-21 08:19:19 UTC
would be cool to be able to right click on a line clicking on "Blame" and get all the hidden documentation you ever wanted about it.

I understand that this is probably some time ahead but just wanted to log the idea somewhere.
Comment 1 Nelson Benitez 2017-12-21 08:07:15 UTC
I am interested in trying to implement this, I envision this feature like a window pops-up with the chunk of code selected and let you navigate backwards the commits that changed that code.

Christian, can you suggest/sketch how do you want this to be implemented? and a small guidance about what files are involved / need to be looked at to implement this?
Comment 2 Christian Hergert 2017-12-24 00:02:03 UTC
(In reply to Nelson Benitez from comment #1)
> I am interested in trying to implement this, I envision this feature like a
> window pops-up with the chunk of code selected and let you navigate
> backwards the commits that changed that code.

Once you start getting into the "navigating" commits, things start getting a lot more complex because we need to think about how we're going to implement VCS integration in terms of commit management. We simply aren't there yet, so it's hard to make a suggestion when there is so much "unknown".

> Christian, can you suggest/sketch how do you want this to be implemented?
> and a small guidance about what files are involved / need to be looked at to
> implement this?

For the simplest form, such as some hover information for a given line, we'd probably need a simple plugin interface that a VCS backend can implement.

Something to get the commit message for a file+line which takes changes in the working directory into account. Then the git plugin should add a new class to implement that interface and register it in ide-git-plugin.c.

Then we'd have to plug that into a tooltip-text provider in the IdeOmniGutterRenderer.
Comment 3 GNOME Infrastructure Team 2018-01-11 09:49:38 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-builder/issues/30.