After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 748345 - basesrc: Remove unused assignment
basesrc: Remove unused assignment
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Mac OS
: Normal minor
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-04-23 00:25 UTC by Changbok
Modified: 2015-04-23 13:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
basesrc: Remove unused assignment (1.00 KB, patch)
2015-04-23 00:29 UTC, Changbok
committed Details | Review

Description Changbok 2015-04-23 00:25:19 UTC
When I have checked seek operation in basesrc, I found some unused assignment.
Also already FIXME comment was added about this assignment.

I can not be sure whether the assignment is used in later. But currently it seems unnecessary in that function.
Comment 1 Changbok 2015-04-23 00:29:12 UTC
Created attachment 302191 [details] [review]
basesrc: Remove unused assignment

update patch file
Comment 2 Tim-Philipp Müller 2015-04-23 13:06:26 UTC
Doesn't look like it might be needed anywhere either, so let's remove it:

commit 60706692b3f4cca71612f80f1b4213f859c35bba
Author: Changbok Chea <changbok.chea@gmail.com>
Date:   Thu Apr 23 09:06:42 2015 +0900

    basesrc: Remove unused assignment in perform_seek()
    
    https://bugzilla.gnome.org/show_bug.cgi?id=748345