After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 747204 - audiofirfilter creates strange noise for smaller filter kernels and even default kernel
audiofirfilter creates strange noise for smaller filter kernels and even defa...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other Linux
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-04-01 20:46 UTC by tobiaswenig
Modified: 2015-05-12 10:42 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description tobiaswenig 2015-04-01 20:46:17 UTC
using audiofirfilter creates strange distorted noises when setting no filter at all (defauilt identity filter is set [1.0]).
I tested with many smaller filters and result was allways same. It seems to work for bigger filter kernels (used DRC filters of ~31000 taps which worked fine). It is reproducible on Ubuntu 14.04 also on commandline:

gst-launch-1.0 filesrc location=/path/to/file \
  ! decodebin \
  ! audioconvert \
  ! audiofirfilter \
  ! autoaudiosink
Comment 1 tobiaswenig 2015-05-11 20:38:12 UTC
it seems only to be relevant for time domain filtering. For all frequency domain filters it seems to work (larger kernels).
Comment 2 Sebastian Dröge (slomo) 2015-05-12 09:35:01 UTC
gst-launch-1.0 audiotestsrc ! audioconvert ! "audio/x-raw,channels=2" ! audiofirfilter ! pulsesink


Works with 1, 2 channels, fails with >2 channels. That's probably related here.
Comment 3 Sebastian Dröge (slomo) 2015-05-12 10:42:51 UTC
commit e11a537b652c03727dc5fcbdb720dda5d6d51469
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Tue May 12 13:41:58 2015 +0300

    audiofxbasefirfilter: Fix time-domain convolution with >1 channels
    
    input_samples is the number of frames, but we used it as the number of
    samples.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=747204