GNOME Bugzilla – Bug 746889
Allow and disallow online accounts
Last modified: 2018-03-26 14:34:37 UTC
Created attachment 300455 [details] page on enabling or disabling some or all online accounts Hello, This procedure explains how to enable or disable some or all online accounts. Any comments are more than welcome. Content-wise, the page has been reviewed by Debarshi Ray. jana
Created attachment 302870 [details] [review] GOA - online accounts, lockdown Hello, I have made significant changes to the document to improve it, thus marking the previous patch "obsolete". Thank you for your comments, jana
Review of attachment 302870 [details] [review]: Looks good to me, Jana. Good job!
Thank you very much, Petr. Pushed to master: commit d93f0d49182deafb6207f4a583a087631c7ed763 jana
Review of attachment 302870 [details] [review]: Petr: It's clear that Jana uses a different page as a template for this one because the parts which are common between a number of the sysadmin guide pages use good style. Unfortunately, all of Jana's additions uses a different style. Petr, why did you let this through the review? I would like the documentation to be as non-intimidating as possible to newcomers, of which keeping to a consistent style is a large part. This page now needs tidying at the very least. New pages especially should be in a good condition when they get committed for the first time. It's now been over 2 years that there have been issues with poor quality reviews. Either the quality of the reviews needs to improve to match the rest of the team or you should not review new pages. Poor pages being let through review cause more work for the rest of the team, which is problematic as there is already strain on the team because of other time commitments.
Review of attachment 302870 [details] [review]: Jana: please include the bug number and the reasoning for the new page in the commit message. Also, please make sure to use the same indentation style as the rest of the project. The rest of the comments are in-line. ::: system-admin-guide/C/lockdown-online-accounts.page @@ +19,3 @@ + <desc>Enable or disable some or all online accounts.</desc> + </info> + <title>Allow or disallow online accounts</title> I think it makes more sense to talk only about enabling and allowing in the titles, not both @@ +22,3 @@ + + <p>The <app>GNOME Online Accounts</app> (GOA) are used for + setting personal network accounts which are then automatically integrated with What do you mean, "are used for setting"? @@ +24,3 @@ + setting personal network accounts which are then automatically integrated with + the GNOME Desktop and applications. The user can add their online accounts, + such as Google, Facebook, Flickr, ownCloud, etc. via the Do not use Latin @@ +31,3 @@ + <item><p>enable all online accounts;</p></item> + <item><p>selectively enable a few online accounts;</p></item> + <item><p>disable all online accounts.</p></item> Our style is to not use punctuation at the end of a list item @@ +50,3 @@ + information for the <sys>local</sys> database containing the following configuration:</p> + <list> + <item><p>For selectively enabling a few providers only:</p> "To enable specific providers:" @@ +52,3 @@ + <item><p>For selectively enabling a few providers only:</p> + <screen>[org/gnome/online-accounts] +whitelisted-providers= ['google', 'facebook']</screen> Explain where these come from. For example, why "google" instead of "Google"? Where can I find a full list?
Jana: also, are online accounts enabled or disabled by default?
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-user-docs/issues/16.