After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 746408 - GLib.Cancellable.set_error_if_cancelled is confusing
GLib.Cancellable.set_error_if_cancelled is confusing
Status: RESOLVED OBSOLETE
Product: vala
Classification: Core
Component: Bindings: GLib
0.27.x
Other Linux
: Normal enhancement
: ---
Assigned To: Vala maintainers
Vala maintainers
Depends on:
Blocks:
 
 
Reported: 2015-03-18 15:49 UTC by Michael Catanzaro
Modified: 2018-05-22 15:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Michael Catanzaro 2015-03-18 15:49:22 UTC 
GLib.Cancellable.set_error_if_cancelled is a bit confusing. What I gather this function does in Vala is throw IOError.Cancelled if the Cancellable has been canceled. A better name for Vala would be Cancellable.throw_error_if_cancelled.
Comment 1 Luca Bruno 2015-03-18 15:51:16 UTC 
I agree but what we can do is creating a new function and deprecate the old one. However note it will be harder to find in the docs. So I don't strongly agree here.
Comment 2 Michael Catanzaro 2015-03-18 17:53:53 UTC 
Why would it be harder to find? I think if you're looking for g_cancellable_set_error_if_cancelled, you're going to find Cancellable.set_error_if_cancelled, and that should point right to Cancellable.throw_error_if_cancelled?
Comment 3 GNOME Infrastructure Team 2018-05-22 15:22:19 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/vala/issues/493.