After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 745972 - update to latest AX_* macros from upstream
update to latest AX_* macros from upstream
Status: RESOLVED FIXED
Product: gnome-photos
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME photos maintainer(s)
GNOME photos maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-03-10 16:48 UTC by Pranav Kant
Modified: 2015-04-27 18:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
build: Updates AX_CHECK_ENABLE_DEBUG macro (2.49 KB, patch)
2015-03-10 16:48 UTC, Pranav Kant
reviewed Details | Review
build: Updates AX_COMPILER_FLAGS macro (8.76 KB, patch)
2015-03-10 16:48 UTC, Pranav Kant
none Details | Review
build: Updates all AX_* macros from upstream (13.08 KB, patch)
2015-03-10 16:48 UTC, Pranav Kant
none Details | Review
build: Updates AX_COMPILER_FLAGS macro (8.27 KB, patch)
2015-03-10 17:07 UTC, Pranav Kant
none Details | Review
build: Updates all AX_* macros from upstream (14.77 KB, patch)
2015-03-10 17:07 UTC, Pranav Kant
none Details | Review
build: Updates AX_COMPILER_FLAGS macro (21.22 KB, patch)
2015-04-09 10:22 UTC, Pranav Kant
accepted-commit_now Details | Review
build: Updates all AX_* macros from upstream (3.50 KB, patch)
2015-04-09 10:22 UTC, Pranav Kant
committed Details | Review
build: Updates all AX_* macros from upstream (3.50 KB, patch)
2015-04-09 18:37 UTC, Pranav Kant
committed Details | Review
build: Update AX_COMPILER_FLAGS macro (21.22 KB, patch)
2015-04-09 18:37 UTC, Pranav Kant
committed Details | Review
build: Update AX_COMPILER_FLAGS_CFLAGS macro (1.79 KB, patch)
2015-04-23 19:39 UTC, Pranav Kant
committed Details | Review

Description Pranav Kant 2015-03-10 16:48:20 UTC
Most importantly, updating to latest macros will eliminate spurious checks for C++ compiler in configure phase.
Comment 1 Pranav Kant 2015-03-10 16:48:29 UTC
Created attachment 299024 [details] [review]
build: Updates AX_CHECK_ENABLE_DEBUG macro

This update to the macro also eliminates the need to pass
$ax_is_release, since it is the default now.
Comment 2 Pranav Kant 2015-03-10 16:48:39 UTC
Created attachment 299025 [details] [review]
build: Updates AX_COMPILER_FLAGS macro

This update, most importantly, removes the C++ compiler checks during
configure phase.

Additionally, it also eliminates the need to pass $ax_is_release, since
it is the default one now.
Comment 3 Pranav Kant 2015-03-10 16:48:50 UTC
Created attachment 299026 [details] [review]
build: Updates all AX_* macros from upstream
Comment 4 Debarshi Ray 2015-03-10 16:59:36 UTC
Review of attachment 299024 [details] [review]:

::: configure.ac
@@ +18,3 @@
 AX_IS_RELEASE([git-directory])
 
+AX_CHECK_ENABLE_DEBUG([yes],,,)

I would prefer to retain the $ax_is_release parameter, unless we don't need to call AX_IS_RELEASE any more, which I don't think is the case. Having it show up in grep avoids any future "why do we need this AX_IS_RELEASE thing" questions, and the examples in https://wiki.gnome.org/Projects/GnomeCommon/Migration have it too.
Comment 5 Pranav Kant 2015-03-10 17:07:27 UTC
Created attachment 299032 [details] [review]
build: Updates AX_COMPILER_FLAGS macro

This update, most importantly, removes the C++ compiler checks during
configure phase.
Comment 6 Pranav Kant 2015-03-10 17:07:38 UTC
Created attachment 299033 [details] [review]
build: Updates all AX_* macros from upstream
Comment 7 Debarshi Ray 2015-03-19 09:18:04 UTC
Review of attachment 299032 [details] [review]:

Thanks for following up on this, Pranav.

The thing is that ax_compiler_flags.m4 is not self-contained. AX_COMPILER_FLAGS requires every other M4 file that was a part of commit e38eb7a75f431224d36d4a871ccecb0b83f85fe6 In this case since we are not going to use the C++ compiler, I think we should remove ax_compiler_flags_cflags.m4 from our tree.

Therefore we should do all these updates as part of this commit.

Here is an example:
https://git.gnome.org/browse/yelp/commit/?id=3b9364324d8545b3bce91f83bd55b10b1b5e3c2e

We already put AX_COMPILER_FLAGS above AC_PROG_CC, so that part can be ignored.
Comment 8 Debarshi Ray 2015-03-19 09:20:17 UTC
Review of attachment 299033 [details] [review]:

Apart from ax_is_release.m4 and ax_check_enable_debug.m4, everything else should be in the other commit.
Comment 9 Debarshi Ray 2015-03-19 09:21:55 UTC
Review of attachment 299032 [details] [review]:

Oops, I typoed. We should consider removing ax_compiler_flags_cxxflags.m4, not ax_compiler_flags_cflags.m4.
Comment 10 Pranav Kant 2015-04-09 10:22:21 UTC
Created attachment 301196 [details] [review]
build: Updates AX_COMPILER_FLAGS macro

This update, most importantly, removes the C++ compiler checks during
configure phase.
Comment 11 Pranav Kant 2015-04-09 10:22:55 UTC
Created attachment 301197 [details] [review]
build: Updates all AX_* macros from upstream
Comment 12 Debarshi Ray 2015-04-09 12:28:18 UTC
Review of attachment 301197 [details] [review]:

Thanks. Looks good.

Minor nitpick: tt should be "Update ...", not "Updates ..." in the commit message.
Comment 13 Debarshi Ray 2015-04-09 18:24:02 UTC
Review of attachment 301196 [details] [review]:

Thanks, Pranav.

It would be worth noting that -Waggregate-return is no longer part of the default warning set.
Comment 14 Debarshi Ray 2015-04-09 18:24:22 UTC
Please push to both master and gnome-3-16.
Comment 15 Pranav Kant 2015-04-09 18:37:02 UTC
The following fixes have been pushed:
2d3d50e build: Updates all AX_* macros from upstream
d12b708 build: Update AX_COMPILER_FLAGS macro
Comment 16 Pranav Kant 2015-04-09 18:37:08 UTC
Created attachment 301233 [details] [review]
build: Updates all AX_* macros from upstream
Comment 17 Pranav Kant 2015-04-09 18:37:16 UTC
Created attachment 301234 [details] [review]
build: Update AX_COMPILER_FLAGS macro

This update, most importantly, removes the C++ compiler checks during
configure phase.
Comment 18 Ting-Wei Lan 2015-04-23 15:52:29 UTC
This update causes error on systems not using bash as /bin/sh because it uses ${flag:5}. Using the latest version of ax_compiler_flags_cflags.m4 can fix this problem.
Comment 19 Pranav Kant 2015-04-23 19:39:10 UTC
Created attachment 302263 [details] [review]
build: Update AX_COMPILER_FLAGS_CFLAGS macro

Prevents error on systems not using bash as /bin/sh.
Comment 20 Debarshi Ray 2015-04-23 21:30:31 UTC
Review of attachment 302263 [details] [review]:

Thanks, Pranav.
Comment 21 Pranav Kant 2015-04-27 18:49:03 UTC
Comment on attachment 302263 [details] [review]
build: Update AX_COMPILER_FLAGS_CFLAGS macro

pushed as 07b35f5 on master
pushed as e6650bf on gnome-3-16