After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 745848 - Use symbolic icons in process list
Use symbolic icons in process list
Status: RESOLVED OBSOLETE
Product: system-monitor
Classification: Core
Component: process list
git master
Other Linux
: Normal normal
: ---
Assigned To: System-monitor maintainers
System-monitor maintainers
Depends on:
Blocks:
 
 
Reported: 2015-03-08 17:37 UTC by Arnaud B.
Modified: 2018-05-22 12:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use symbolic icons for HighContrast (5.71 KB, patch)
2015-03-15 17:05 UTC, Robert Roth
none Details | Review
Use symbolic icons for HighContrast v2 (4.08 KB, patch)
2015-03-15 18:15 UTC, Benoît Dejean
accepted-commit_now Details | Review
HighContrast screenshot (176.25 KB, image/png)
2015-03-15 21:32 UTC, Robert Roth
  Details
Screenshot. (20.38 KB, image/png)
2015-03-15 21:49 UTC, Arnaud B.
  Details

Description Arnaud B. 2015-03-08 17:37:44 UTC
Beginning with 3.15.90, symbolic icons are now displayed in the Shell’s top-bar, and used as main icons when using HighContrast theme.

The process list should probably try to use the same “small icon” the users are used to, so prefer symbolic icons over small hicolor ones. And it should primarily use them when in HighContrast theme.
Comment 1 Robert Roth 2015-03-15 17:05:12 UTC
Created attachment 299461 [details] [review]
Use symbolic icons for HighContrast
Comment 2 Robert Roth 2015-03-15 17:06:01 UTC
@Arnaud: could you please check if this (the behaviour with the patch applied) was the thing you had in mind?
Comment 3 Benoît Dejean 2015-03-15 18:15:52 UTC
Created attachment 299462 [details] [review]
Use symbolic icons for HighContrast v2

Same as Robert's patch, but don't lookup for the theme on each icon load + patch maniac cleanup.
Comment 4 Robert Roth 2015-03-15 19:35:03 UTC
Review of attachment 299462 [details] [review]:

Thanks for the improvements, they are required indeed.
Comment 5 Arnaud B. 2015-03-15 21:16:31 UTC
I had in mind that symbolic icons could be used even in hicolor theme, as they are the default icons now in the top bar, whatever theme is used.

Testing the first patch (cannot apply the second with `git am` (?!)) in HighContrast theme, I see that symbolic icons are rendered really light on white, so that is probably not suitable for visually impaired people. There should be a way to render them black on white (as it’s done in buttons).
Comment 6 Robert Roth 2015-03-15 21:31:51 UTC
(In reply to Arnaud Bonatti from comment #5)
> I had in mind that symbolic icons could be used even in hicolor theme, as
> they are the default icons now in the top bar, whatever theme is used.
> 
> Testing the first patch (cannot apply the second with `git am` (?!)) in
> HighContrast theme, I see that symbolic icons are rendered really light on
> white, so that is probably not suitable for visually impaired people. There
> should be a way to render them black on white (as it’s done in buttons).

Strange, for me symbolic icons are rendered black on white, see the attached screenshot. I'm running 3.14.x though, so I'm not sure this will not change with 3.16.x.
Comment 7 Robert Roth 2015-03-15 21:32:31 UTC
Created attachment 299468 [details]
HighContrast screenshot
Comment 8 Arnaud B. 2015-03-15 21:49:29 UTC
Created attachment 299470 [details]
Screenshot.

That would be a wonderful rendering. It’s not rendered like that on master; on the screenshot, `gnome-system-monitor` and `polari` use a symbolic icon (`gnome-shell` and `dconf-service` has a HighContrast one). I know some things changed days ago[1] in gtk+ about the rendering of symbolic icons, I’ll check if it’s not introduced by this commit.

[1] https://git.gnome.org/browse/gtk+/commit/?id=d2881d901bc057328d4096bb86830198816fd1a2
Comment 9 Arnaud B. 2015-03-15 22:36:12 UTC
(No, it wasn’t.)
Comment 10 Benoît Dejean 2015-03-16 11:07:35 UTC
I have the same rendering than Arnaud. Many programs have a correct HiContract Icon, but some like system-monitor have instead a gray one.
Comment 11 Robert Roth 2015-03-16 19:39:44 UTC
After a discussion on #gtk+ with mclasen the outcome was that we shouldn't do anything else then use -symbolic icon-names in case of highcontrast theme, so no messing with the flags should be required and gtk+ should automagically handle it. 
Patches are welcome, but I wouldn't like to start shooting blindly with patches, as I don't have 3.15.x handy yet. So unless someone suggests a patch fixing the issue using "-symbolic" icon names I'll leave this for the next cycle/
Comment 12 GNOME Infrastructure Team 2018-05-22 12:15:01 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-system-monitor/issues/53.