After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 745748 - liveadder: Fix memory leak
liveadder: Fix memory leak
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.5.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-03-06 14:56 UTC by sancane
Modified: 2015-06-10 08:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch generated using git format-patch (2.10 KB, patch)
2015-03-06 14:57 UTC, sancane
needs-work Details | Review
patch from Santiago Carot-Nemesio reworked for master (1.47 KB, patch)
2015-06-09 14:58 UTC, Nicolas Huet
committed Details | Review

Description sancane 2015-03-06 14:56:27 UTC
liveadder neither unsets nor resets the item GValue when iterating over pads.
Comment 1 sancane 2015-03-06 14:57:33 UTC
Created attachment 298716 [details] [review]
patch generated using git format-patch
Comment 2 Sebastian Dröge (slomo) 2015-06-09 08:16:46 UTC
Comment on attachment 298716 [details] [review]
patch generated using git format-patch

This does not apply to GIT master anymore.


Is there any reason why you use liveadder instead of the new audiomixer element?
Comment 3 sancane 2015-06-09 09:53:11 UTC
I used to, those are some leaks I detected. I had no idea about the future of liveadder, any case these were my two cents for all those who still want to use liveadder even though it's gonna be deprecated.
Comment 4 Nicolas Huet 2015-06-09 13:31:36 UTC
In audiomixer comment, we can read this comment:
 * The audiomixer currently mixes all data received on the sinkpads as soon as
 * possible without trying to synchronize the streams.

As I need synchonization, I still use liveadder.
Comment 5 Tim-Philipp Müller 2015-06-09 13:40:22 UTC
> In audiomixer comment, we can read this comment:
>  * The audiomixer currently mixes all data received on the sinkpads as soon
> as
>  * possible without trying to synchronize the streams.
> 
> As I need synchonization, I still use liveadder.

I don't think that comment is correct, it was just copied over from the adder documentation. audiomixer should synchronise input streams correctly.
Comment 6 Nicolas Huet 2015-06-09 13:48:39 UTC
On my side, I have few modification in liveadder to avoid starting timestamp from 0:00:00. 

I did not have time yet to report these modifications in audiomixer.
Comment 7 Tim-Philipp Müller 2015-06-09 14:11:48 UTC
So is anyone going to update the patch then? :)
Comment 8 Nicolas Huet 2015-06-09 14:58:47 UTC
Created attachment 304868 [details] [review]
patch from Santiago Carot-Nemesio reworked for master