After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 745518 - http.playback.reverse_playback.vorbis_theora.1.ogg should be failed
http.playback.reverse_playback.vorbis_theora.1.ogg should be failed
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-devtools
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-03-03 11:15 UTC by Young Han Lee
Modified: 2018-11-03 11:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
vorbis_theora_1_ogg.validate.logs (8.13 KB, text/plain)
2015-03-03 12:23 UTC, Young Han Lee
  Details
Add 'error' action (2.21 KB, patch)
2015-03-08 07:40 UTC, Young Han Lee
none Details | Review
Add 'error' action (2.32 KB, patch)
2015-03-09 12:10 UTC, Young Han Lee
none Details | Review
New patch to test rate after a seek (2.97 KB, patch)
2015-03-10 13:13 UTC, Young Han Lee
reviewed Details | Review

Description Young Han Lee 2015-03-03 11:15:47 UTC
http.playback.reverse_playback.vorbis_theora.1.ogg seems to have false negative result.

reverse_playback makes test media playback from end of file to 0 for testing reverse playback, but in this test vorbis_theora.1.ogg is played from 0 to end of file. So, while this test seems like it should fail, it actually 'passed' because it is ended successfully. The test scenario need to be modified to achieve intented result.
Comment 1 Young Han Lee 2015-03-03 12:23:04 UTC
Created attachment 298418 [details]
vorbis_theora_1_ogg.validate.logs

my vorbis_theora_1_ogg.validate.logs file is attached.
Comment 2 Young Han Lee 2015-03-03 12:42:34 UTC
How about adding, for example, 'error' action type like following.

(reverse_playback.scenario)
description, seek=true, reverse-playback=true, min-media-duration=4.0
seek, name=Revserse-seek, playback-time=0.0, rate=-1.0, start=0.0, stop=duration, flags=accurate+flush
error, name=should-not-be-reached, playback-time=1.0
eos, playback-time=3.0
Comment 3 Young Han Lee 2015-03-08 07:40:46 UTC
Created attachment 298796 [details] [review]
Add 'error' action

Attach a patch for discussion.
Comment 4 Young Han Lee 2015-03-09 12:10:23 UTC
Created attachment 298871 [details] [review]
Add 'error' action
Comment 5 Thibault Saunier 2015-03-10 13:00:55 UTC
As discussed on IRC your solution is not waht should be done fmpov.

I proposed a solution at http://phabricator.freedesktop.org/D35 where I verify that the position reporting decrease if the rate of the last seek < 0 and increase otherwize.

would be nice if you could check it out.
Comment 6 Young Han Lee 2015-03-10 13:13:31 UTC
Created attachment 298990 [details] [review]
New patch to test rate after a seek

This change tests rate is set properly after a seek. In the result, this makes the following test failed which were passed but false negative.

validate.http.playback.reverse_playback.vorbis_theora_1_ogg

One weird side-effect is that some fast-forward tests fail additionally if gst-validate-launch runs with -j option. In this case, the rate value immediately checked after seek and async-done is not changed, so test fails. I have a plan to investigate this problem.


p.s. Thibault Saunier, I created this patch before reading your comment. I'll test your suggestion soon.
Comment 7 Thibault Saunier 2015-03-10 13:16:55 UTC
Review of attachment 298990 [details] [review]:

It is pretty much the same thing as what I proposed, can you check the patch I proposed at: http://phabricator.freedesktop.org/D35 ?

::: validate/gst/validate/gst-validate-report.h
@@ +87,3 @@
 #define EVENT_SEEK_NOT_HANDLED                   _QUARK("event::seek-not-handled")
 #define EVENT_SEEK_RESULT_POSITION_WRONG         _QUARK("event::seek-result-position-wrong")
+#define EVENT_SEEK_RESULT_RATE_WRONG             _QUARK("event::seek-result-rate-wrong")

You would have to also register that type, without doing it reporting will just no work I think
Comment 8 Thibault Saunier 2015-03-10 13:18:34 UTC
Review of attachment 298990 [details] [review]:

It is pretty much the same thing as what I proposed, can you check the patch I proposed at: http://phabricator.freedesktop.org/D35 ?

::: validate/gst/validate/gst-validate-report.h
@@ +87,3 @@
 #define EVENT_SEEK_NOT_HANDLED                   _QUARK("event::seek-not-handled")
 #define EVENT_SEEK_RESULT_POSITION_WRONG         _QUARK("event::seek-result-position-wrong")
+#define EVENT_SEEK_RESULT_RATE_WRONG             _QUARK("event::seek-result-rate-wrong")

You would have to also register that type, without doing it reporting will just no work I think
Comment 9 Thibault Saunier 2015-03-10 13:18:34 UTC
Review of attachment 298990 [details] [review]:

It is pretty much the same thing as what I propose

::: validate/gst/validate/gst-validate-report.h
@@ +87,3 @@
 #define EVENT_SEEK_NOT_HANDLED                   _QUARK("event::seek-not-handled")
 #define EVENT_SEEK_RESULT_POSITION_WRONG         _QUARK("event::seek-result-position-wrong")
+#define EVENT_SEEK_RESULT_RATE_WRONG             _QUARK("event::seek-result-rate-wrong")

You would have to also register that type, without doing it reporting will just no work I think
Comment 10 Thibault Saunier 2015-03-10 13:18:34 UTC
Review of attachment 298990 [details] [review]:

It is pretty much the same thing as what I propose

::: validate/gst/validate/gst-validate-report.h
@@ +87,3 @@
 #define EVENT_SEEK_NOT_HANDLED                   _QUARK("event::seek-not-handled")
 #define EVENT_SEEK_RESULT_POSITION_WRONG         _QUARK("event::seek-result-position-wrong")
+#define EVENT_SEEK_RESULT_RATE_WRONG             _QUARK("event::seek-result-rate-wrong")

You would have to also register that type, without doing it reporting will just no work I think
Comment 11 Thibault Saunier 2015-03-10 13:18:39 UTC
Review of attachment 298990 [details] [review]:

It is pretty much the same thing as what I proposed but my patch is a bit more complete I think.

::: validate/gst/validate/gst-validate-report.h
@@ +87,3 @@
 #define EVENT_SEEK_NOT_HANDLED                   _QUARK("event::seek-not-handled")
 #define EVENT_SEEK_RESULT_POSITION_WRONG         _QUARK("event::seek-result-position-wrong")
+#define EVENT_SEEK_RESULT_RATE_WRONG             _QUARK("event::seek-result-rate-wrong")

You would have to also register that type, without doing it reporting will just no work I think
Comment 12 Thibault Saunier 2015-03-10 13:18:43 UTC
Review of attachment 298990 [details] [review]:

It is pretty much the same thing as what I proposed but my patch is a bit more complete I think.

::: validate/gst/validate/gst-validate-report.h
@@ +87,3 @@
 #define EVENT_SEEK_NOT_HANDLED                   _QUARK("event::seek-not-handled")
 #define EVENT_SEEK_RESULT_POSITION_WRONG         _QUARK("event::seek-result-position-wrong")
+#define EVENT_SEEK_RESULT_RATE_WRONG             _QUARK("event::seek-result-rate-wrong")

You would have to also register that type, without doing it reporting will just no work I think
Comment 13 Thibault Saunier 2015-03-10 13:19:34 UTC
OK, really sorry about that, I pressed several time the "commit" button because it looked like it was not working.
Comment 14 Young Han Lee 2015-03-10 13:23:49 UTC
It's okay :)

I'm testing your patch to check whether there is the side-effect I experienced.
Comment 15 Young Han Lee 2015-03-29 02:10:56 UTC
This issue is waiting for merge of the patch in http://phabricator.freedesktop.org/D35
Comment 16 Thibault Saunier 2015-03-29 11:11:19 UTC
(In reply to Young Han Lee from comment #15)
> This issue is waiting for merge of the patch in
> http://phabricator.freedesktop.org/D35

I have it in mind but found regressions in the GES testsuite due to it so I need to find some time to investigate that before merging.
Comment 17 GStreamer system administrator 2018-11-03 11:06:41 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-devtools/issues/12.