After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 745162 - display legacy status icons somewhere
display legacy status icons somewhere
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: message-tray
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2015-02-25 14:54 UTC by Matthias Clasen
Modified: 2016-06-25 08:51 UTC
See Also:
GNOME target: 3.16
GNOME version: ---


Attachments
legacyTray: Add a hideable tray for legacy status icons (11.54 KB, patch)
2015-03-03 10:25 UTC, Florian Müllner
none Details | Review
legacyTray: Move to the left ... (3.71 KB, patch)
2015-03-03 10:25 UTC, Florian Müllner
none Details | Review
legacyTray: Add a hideable tray for legacy status icons (11.70 KB, patch)
2015-03-03 14:57 UTC, Florian Müllner
none Details | Review
legacyTray: Add a hideable tray for legacy status icons (12.13 KB, patch)
2015-03-03 17:36 UTC, Florian Müllner
committed Details | Review
new systray over windows, blocking content (17.52 KB, image/png)
2015-03-28 21:34 UTC, Branko Grubic (bitlord)
  Details

Description Matthias Clasen 2015-02-25 14:54:56 UTC
The new notification design doesn't subsume status icons among notifications anymore, which is good. We consider them legacy and want to discourage their use, but we still need to let users use application that rely on status icons as an important part of their UI.
Comment 1 Florian Müllner 2015-03-03 10:25:31 UTC
Created attachment 298405 [details] [review]
legacyTray: Add a hideable tray for legacy status icons

This implements Jakub's mockup - Allan suggested to move it to the other side, I'll attach that as a separate patch on top of this one, so that we can try out both ...
Comment 2 Florian Müllner 2015-03-03 10:25:38 UTC
Created attachment 298406 [details] [review]
legacyTray: Move to the left ...

... as suggested by Allan.
Comment 3 Florian Müllner 2015-03-03 14:57:23 UTC
Created attachment 298439 [details] [review]
legacyTray: Add a hideable tray for legacy status icons

So the left it is - squashed both patches and did some minor style tweaks.
Comment 4 Carlos Soriano 2015-03-03 15:20:27 UTC
Review of attachment 298439 [details] [review]:

::: js/ui/legacyTray.js
@@ +94,3 @@
+                Tweener.removeTweens(this._slider);
+                Tweener.addTween(this._slider, { opacity: 0,
+                                               time: Overview.ANIMATION_TIME,

space missing

@@ +95,3 @@
+                Tweener.addTween(this._slider, { opacity: 0,
+                                               time: Overview.ANIMATION_TIME,
+                                               transition: 'easeOutQuad' });

dito

@@ +103,3 @@
+                Tweener.removeTweens(this._slider);
+                Tweener.addTween(this._slider, { opacity: 255,
+                                               time: Overview.ANIMATION_TIME,

dito

@@ +104,3 @@
+                Tweener.addTween(this._slider, { opacity: 255,
+                                               time: Overview.ANIMATION_TIME,
+                                               transition: 'easeOutQuad' });

dito

@@ +157,3 @@
+
+        if (!this.actor.visible)
+            return;

Can't we have here some weird slide animation if we don't set the slideX value always?
Like actor visible, conceal handle not visible, so it animates from a invalid position calculated before to the new correct one (althought this can't happen probably, just an example). Or some weird couple of things together that could put it in a weird state...

I remember having some issues with the dash etc because of inconsistency on the slide position... so just to make sure we could slideX = 0 here.

Feel free to ignore if you are sure.
Comment 5 Florian Müllner 2015-03-03 17:36:35 UTC
Created attachment 298458 [details] [review]
legacyTray: Add a hideable tray for legacy status icons

(In reply to Carlos Soriano from comment #4)
> +                                               time:
> Overview.ANIMATION_TIME,
> 
> space missing

Ah yeah - used to be "this.actor" and I forgot to reindent when changing it. Fixed.


> @@ +157,3 @@
> +
> +        if (!this.actor.visible)
> +            return;
> 
> Can't we have here some weird slide animation if we don't set the slideX
> value always?

Probably not, at least I didn't encounter anything in testing. Still, here's a version that does less special-casing, just to be safe ...
Comment 6 Carlos Soriano 2015-03-03 18:08:10 UTC
Review of attachment 298458 [details] [review]:

Yep! Thanks!
Comment 7 Florian Müllner 2015-03-03 18:20:05 UTC
Attachment 298458 [details] pushed as 874cf0b - legacyTray: Add a hideable tray for legacy status icons
Comment 8 sébastien lafargue 2015-03-21 17:43:35 UTC
Hi,

I have a double screen configuration with primary on right.
My concerns are :

- I don't like having this on my screen because it can mask part of my apps
- Even without icons on it and so no tray shown, there's still a pointer barrier
Comment 9 Branko Grubic (bitlord) 2015-03-28 21:33:21 UTC
Current design doesn't solve problems, and make new ones, can we please have this fixed? 
I think the best solution while legacy icons are still needed is already available, you just need to include it. 
https://extensions.gnome.org/extension/495/topicons/ 

Extensions are good, but they can break you system, and for something like this, it should be included by default.
Comment 10 Branko Grubic (bitlord) 2015-03-28 21:34:09 UTC
Created attachment 300524 [details]
new systray over windows, blocking content
Comment 11 Allan Day 2015-03-30 10:38:48 UTC
(In reply to (bitlord) from comment #10)
> Created attachment 300524 [details]
> new systray over windows, blocking content

That issue is covered by bug 746787 - let's deal with it there.
Comment 12 Nguyen Thai Ngoc Duy 2016-06-25 08:27:21 UTC
(In reply to Florian Müllner from comment #1)
> Created attachment 298405 [details] [review] [review]
> legacyTray: Add a hideable tray for legacy status icons
> 
> This implements Jakub's mockup - Allan suggested to move it to the other
> side

May I know the reason? Current tray would still hide half the character when it's hidden. And "1" or "l" could be completely hidden. I would think moving the tray to the right would make this problem go away.
Comment 13 Florian Müllner 2016-06-25 08:37:04 UTC
(In reply to Nguyen Thai Ngoc Duy from comment #12)
> (In reply to Florian Müllner from comment #1)
> > This implements Jakub's mockup - Allan suggested to move it to the other
> > side
> 
> May I know the reason?

The right side is more likely to interfere with controls (scrollbar steppers come to mind). Not all windows are terminals :-)
Comment 14 Nguyen Thai Ngoc Duy 2016-06-25 08:51:10 UTC
(In reply to Florian Müllner from comment #13)
> (In reply to Nguyen Thai Ngoc Duy from comment #12)
> > (In reply to Florian Müllner from comment #1)
> > > This implements Jakub's mockup - Allan suggested to move it to the other
> > > side
> > 
> > May I know the reason?
> 
> The right side is more likely to interfere with controls (scrollbar steppers
> come to mind). Not all windows are terminals :-)

Right. Makes sense. It's still annoying for terminal users though. Perhaps making the strip a circle and sticking it at the left bottom (so only a quarter of the circle shows up) will be better? Discoverability is already pretty good when the legacy tray temporarily shows up when new icons are added.