After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 744048 - Reimplement the live clip trimming preview as a popover widget?
Reimplement the live clip trimming preview as a popover widget?
Status: RESOLVED OBSOLETE
Product: pitivi
Classification: Other
Component: Timeline
Git
Other Linux
: Normal enhancement
: Git
Assigned To: Thibault Saunier
Pitivi maintainers
Depends on:
Blocks:
 
 
Reported: 2015-02-05 15:36 UTC by Jean-François Fortin Tam
Modified: 2015-10-20 13:30 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Jean-François Fortin Tam 2015-02-05 15:36:09 UTC
In the "gtktimeline" branch, the "live trim preview" feature (http://jeff.ecchi.ca/blog/2012/03/07/trim-like-a-professional-hair-stylist/)
is broken. Possibly the signal isn't getting fired just because it's blocked by this unrelated traceback when trimming:

Traceback (most recent call last):
  • File "pitivi/timeline/elements.py", line 389 in do_draw
    self._drawKeyframeCurve(cr)
  • File "pitivi/timeline/elements.py", line 376 in _drawKeyframeCurve
    (clipped_rect.x + clipped_rect.width))
  • File "pitivi/timeline/elements.py", line 276 in draw
    self._plot(start, end)
  • File "pitivi/timeline/elements.py", line 214 in _plot
    self._createVisibleValues()
  • File "pitivi/timeline/elements.py", line 183 in _createVisibleValues
    self._line_ys.append(self.interpolate_value(low_bound, value,
UnboundLocalError: local variable 'low_bound' referenced before assignment


So the first step is to make the existing feature work.

The second step would be to experiment with a gtk popover to hold the trimming preview right over the trimming handle. I think it would an improvement as the eye would stay contextualized (given a reasonably sized popover ;), it would look nice visually, and would have some technical advantages (not swapping pipelines and such from the main viewer), and allow keeping the view of the frame of at the playhead in the viewer at all times.
Comment 1 Jean-François Fortin Tam 2015-05-14 01:30:10 UTC
The old trimming preview feature works again in thiblahute's branch. Changing to enhancement for the 2nd part.
Comment 2 Thibault Saunier 2015-10-20 13:30:58 UTC
This bug has been migrated to https://phabricator.freedesktop.org/T3273.

Please use the Phabricator interface to report further bugs by creating a task and associating it with Project: Pitivi.

See http://wiki.pitivi.org/wiki/Bug_reporting for details.