After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 744020 - Auto-disabling of Desktop OpenGL when it can't be used doesn't work
Auto-disabling of Desktop OpenGL when it can't be used doesn't work
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
1.4.5
Other Linux
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-02-04 23:20 UTC by Andrei Slavoiu
Modified: 2015-03-14 19:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gst-plugins-bad-1.4.5-fix-both-opengl-gles2.patch (2.88 KB, patch)
2015-02-04 23:22 UTC, Andrei Slavoiu
none Details | Review

Description Andrei Slavoiu 2015-02-04 23:20:53 UTC
The "X, GLX and OpenGL" block would set USE_OPENGL based on the value of HAVE_GL before the "check if we can include both GL and GLES2 at the same time" block is executed and sets HAVE_GL to false.

Attached patch also fixes 2 typos I found in the process.
Comment 1 Andrei Slavoiu 2015-02-04 23:22:06 UTC
Created attachment 296157 [details] [review]
gst-plugins-bad-1.4.5-fix-both-opengl-gles2.patch
Comment 2 Matthew Waters (ystreet00) 2015-02-05 06:26:18 UTC
Good catch!

It's probably simpler to backport http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/?id=aeaf4a4388aaaf4eadcbf398664bd4a5d45d070a for the USE_OPENGL issue.  The two typos need fixing and require a separate patch using git format-patch :)
Comment 3 Matthew Waters (ystreet00) 2015-03-14 19:56:00 UTC
commit 13049caaf2f2272efc6c8e8604992c217e0f898c
Author: Matthew Waters <matthew@centricular.com>
Date:   Sat Mar 14 11:01:12 2015 +0000

    gl: fix a couple of typos in configure.ac
    
    https://bugzilla.gnome.org/show_bug.cgi?id=744020