After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 743738 - tracker-compat: put absolute path in shell script
tracker-compat: put absolute path in shell script
Status: RESOLVED FIXED
Product: tracker
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: tracker-general
tracker-general
: 745546 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2015-01-30 13:29 UTC by Dominique Leuenberger
Modified: 2015-03-05 21:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
tracker-compat: put absolute path in shell script (1.39 KB, patch)
2015-01-30 13:29 UTC, Dominique Leuenberger
none Details | Review
improved patch (1.92 KB, patch)
2015-03-03 18:29 UTC, David King
committed Details | Review

Description Dominique Leuenberger 2015-01-30 13:29:42 UTC
the file installed as /usr/bin/tracker-compat (and copied to all other commands) tries to start ./tracker, which only ever works for a dev being in the right path.
Comment 1 Dominique Leuenberger 2015-01-30 13:29:45 UTC
Created attachment 295801 [details] [review]
tracker-compat: put absolute path in shell script
Comment 2 Bastien Nocera 2015-03-03 17:44:21 UTC
*** Bug 745546 has been marked as a duplicate of this bug. ***
Comment 3 Bastien Nocera 2015-03-03 17:45:16 UTC
Review of attachment 295801 [details] [review]:

That looks correct to me.
Comment 4 David King 2015-03-03 18:29:02 UTC
Created attachment 298464 [details] [review]
improved patch

A better approach is to do this at make time, rather than as a configure substitution. This is similar to how the substitution is done in other places in tracker.
Comment 5 Martyn Russell 2015-03-05 19:02:19 UTC
Review of attachment 298464 [details] [review]:

Patch looks right to me, please commit.
Comment 6 David King 2015-03-05 21:34:57 UTC
Review of attachment 298464 [details] [review]:

Thanks! Pushed to master as 0cdace326033d3a2d246a817e026807f1a61f71a.