After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 743647 - image-missing is missing from libgtk's resources
image-missing is missing from libgtk's resources
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2015-01-28 14:19 UTC by Lars Karlitski
Modified: 2015-02-18 17:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Also bundle icons in status/ as resources (1.12 KB, patch)
2015-01-28 14:19 UTC, Lars Karlitski 		committed Details | Review
build: Don't use shopt in the build command (1.00 KB, patch)
2015-02-18 16:21 UTC, Ting-Wei Lan 		committed Details | Review

Description Lars Karlitski 2015-01-28 14:19:28 UTC 
Which results in gtk crashing when the theme doesn't have that icon.

The icons already exist in the gtk/icons/*/status/, but weren't added to the
resource file.
Comment 1 Lars Karlitski 2015-01-28 14:19:30 UTC 
Created attachment 295669 [details] [review]
Also bundle icons in status/ as resources
Comment 2 Matthias Clasen 2015-01-28 14:21:15 UTC 
Review of attachment 295669 [details] [review]:

Oops. Thanks for catching this
Comment 3 Matthias Clasen 2015-01-28 14:21:24 UTC 
Review of attachment 295669 [details] [review]:

Oops. Thanks for catching this
Comment 4 Lars Karlitski 2015-01-28 14:27:24 UTC 
Attachment 295669 [details] pushed as 8e8a94b - Also bundle icons in status/ as resources
Comment 5 Ting-Wei Lan 2015-02-16 16:23:23 UTC 
`shopt' command is not supported by POSIX, so it causes error on systems not using bash as the default shell.

  GEN      gtk.gresource.xml
shopt: not found
  GEN      gtkresources.h
gtk.gresource.xml: Failed to locate 'icons/22x22/status/*.png' in any source directory.
Comment 6 Ting-Wei Lan 2015-02-18 16:21:17 UTC 
Created attachment 297107 [details] [review]
build: Don't use shopt in the build command
Comment 7 Matthias Clasen 2015-02-18 17:13:43 UTC 
Review of attachment 297107 [details] [review]:

Looks good to me
Comment 8 Ting-Wei Lan 2015-02-18 17:30:41 UTC 
Attachment 297107 [details] pushed as 359fc25 - build: Don't use shopt in the build command