After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 743400 - Allow reordering of input layouts
Allow reordering of input layouts
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Keyboard
3.14.x
Other Linux
: Normal normal
: ---
Assigned To: Rui Matos
Control-Center Maintainers
: 747522 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2015-01-23 13:27 UTC by Pacho Ramos
Modified: 2015-04-08 17:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
region: Join the input source settings and layout buttons (2.22 KB, patch)
2015-02-10 13:48 UTC, Rui Matos
committed Details | Review
region: Implement input source list re-ordering (11.36 KB, patch)
2015-02-10 13:48 UTC, Rui Matos
none Details | Review
how it looks (28.09 KB, image/png)
2015-02-16 13:40 UTC, Rui Matos
  Details
region: Add accessible names to toolbar buttons (3.43 KB, patch)
2015-02-26 14:58 UTC, Rui Matos
committed Details | Review
region: Implement input source list re-ordering (11.94 KB, patch)
2015-02-26 14:58 UTC, Rui Matos
committed Details | Review

Description Pacho Ramos 2015-01-23 13:27:19 UTC
If I set up two keymaps in Control Center (Spanish and English-US for example) and, then, I select the english keymap to my user session, every time I logout and login I need to change from spanish to english keymap.

Looks like the default setting in:
# localectl 
   System Locale: LANG=es_ES.UTF-8
                  LC_COLLATE=C
       VC Keymap: es
      X11 Layout: es
     X11 Options: terminate:ctrl_alt_bksp

is always used no matter a user changes it for his/her session

Thanks
Comment 1 Bastien Nocera 2015-01-26 12:57:52 UTC
(In reply to comment #0)
> If I set up two keymaps in Control Center (Spanish and English-US for example)
> and, then, I select the english keymap to my user session, every time I logout
> and login I need to change from spanish to english keymap.

Then the English keymap is actually still there, but Spanish is the first one in the list, and selected when you log in. Is that correct?
Comment 2 Pacho Ramos 2015-01-26 13:29:41 UTC
Exactly, it doesn't remember that the concrete user wants to use english keyboard (even if the rest still want spanish as default)
Comment 3 Bastien Nocera 2015-01-26 13:34:32 UTC
You can solve that easily for that user by removing the spanish layout, and re-adding it. The English layout will be first in the list, and used by default. Nothing to do with the system default being Spanish.

Rui, do we have a bug about the re-ordering of input sources?
Comment 4 Pacho Ramos 2015-01-26 13:38:55 UTC
Ah, thanks, will inform about the workaround :)
Comment 5 Rui Matos 2015-02-10 13:48:31 UTC
Created attachment 296508 [details] [review]
region: Join the input source settings and layout buttons

Currently it looks a bit unpolished that the add/remove buttons on the
other side of the toolbar look linked while this pair doesn't. Note
that the input source settings button isn't always visible but in that
case the layout button will still show up correctly as non-linked.
Comment 6 Rui Matos 2015-02-10 13:48:39 UTC
Created attachment 296509 [details] [review]
region: Implement input source list re-ordering

The first input source gets activated by default when users log in but
we don't currently allow users to set this (other than the awkward
remove all input sources and add them again in the right order).

Allowing user re-ordering of the input source list nicely allows users
to get the default input source they want.
Comment 7 Rui Matos 2015-02-10 13:50:14 UTC
(In reply to Bastien Nocera from comment #3)
> Rui, do we have a bug about the re-ordering of input sources?

This is it. There's bug 737647 but I'll leave that one for the re-design which won't be happening for 3.16 yet. I'd like to go with the above patches as a stop-gap for now.
Comment 8 Rui Matos 2015-02-16 13:40:57 UTC
Created attachment 296929 [details]
how it looks
Comment 9 Allan Day 2015-02-25 17:39:55 UTC
(In reply to Rui Matos from comment #8)
> Created attachment 296929 [details]
> how it looks

I'm not a huge fan of the up/down arrow buttons, but OK.
Comment 10 Bastien Nocera 2015-02-25 17:44:57 UTC
Review of attachment 296508 [details] [review]:

Sure.
Comment 11 Bastien Nocera 2015-02-25 17:48:56 UTC
Review of attachment 296509 [details] [review]:

Rest looks good.

::: panels/region/cc-region-panel.c
@@ +1265,3 @@
+        gint idx;
+
+        if (op != MOVE_UP_INPUT && op != MOVE_DOWN_INPUT)

g_assert instead here.

@@ +1269,3 @@
+
+        selected = gtk_list_box_get_selected_row (GTK_LIST_BOX (priv->input_list));
+        if (selected == NULL)

Ditto.

::: panels/region/region.ui
@@ +298,3 @@
+                        </child>
+                        <child>
+                          <object class="GtkButton" id="input_source_down">

Please add some label to the buttons so that they are spoken for a11y purposes.
Comment 12 Rui Matos 2015-02-26 14:58:12 UTC
Created attachment 297988 [details] [review]
region: Add accessible names to toolbar buttons
Comment 13 Rui Matos 2015-02-26 14:58:42 UTC
Created attachment 297990 [details] [review]
region: Implement input source list re-ordering

--

Review comments addressed, thanks
Comment 14 Rui Matos 2015-02-28 20:02:56 UTC
Got the freeze break approvals[1], pushing

[1] https://mail.gnome.org/archives/release-team/2015-February/msg00101.html

Attachment 296508 [details] pushed as 44b3679 - region: Join the input source settings and layout buttons
Attachment 297988 [details] pushed as da060fa - region: Add accessible names to toolbar buttons
Attachment 297990 [details] pushed as 87640bb - region: Implement input source list re-ordering
Comment 15 Bastien Nocera 2015-04-08 17:20:34 UTC
*** Bug 747522 has been marked as a duplicate of this bug. ***