After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 743013 - v4l2bufferpool: set v4l2_buffer.field when queuing buffer in an output device
v4l2bufferpool: set v4l2_buffer.field when queuing buffer in an output device
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-01-16 09:23 UTC by Aurélien Zanelli
Modified: 2015-02-25 15:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
v4l2bufferpool: set v4l2_buffer.field when queuing buffer in an output device (1.84 KB, patch)
2015-01-16 09:25 UTC, Aurélien Zanelli
committed Details | Review

Description Aurélien Zanelli 2015-01-16 09:23:41 UTC
Currently, while running pipeline with a v4l2sink, I've a lot of
"FIXME Unhandled enum v4l2_field 0 - treating as progressive"
when dequeuing buffers.

Although checking field value when dequeuing a buffer from an output device is not very relevant as the buffer will just go into the bufferpool to further use, it help be found out that when we queue buffers, we don't set the v4l2_buffer.field to a valid value as required by the current specification foran output device.
Comment 1 Aurélien Zanelli 2015-01-16 09:25:58 UTC
Created attachment 294656 [details] [review]
v4l2bufferpool: set v4l2_buffer.field when queuing buffer in an output device

Proposal patch to set field when queuing buffer in output device
Comment 2 Nicolas Dufresne (ndufresne) 2015-02-25 15:46:05 UTC
Review of attachment 294656 [details] [review]:

commit e57bc4386292e3f47e1bfec72973b37aee6f3625
Author: Aurélien Zanelli <aurelien.zanelli@parrot.com>
Date:   Thu Jan 15 16:11:53 2015 +0100

    v4l2bufferpool: set v4l2_buffer.field when queuing buffer in an output device
    
    According to the current specification, application must set this field
    for an output device.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=743013