After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 742536 - fuzzy timeline text on HiDPI display
fuzzy timeline text on HiDPI display
Status: RESOLVED OBSOLETE
Product: pitivi
Classification: Other
Component: User interface
0.94
Other Linux
: Normal normal
: Git
Assigned To: Pitivi maintainers
Pitivi maintainers
Depends on:
Blocks:
 
 
Reported: 2015-01-07 17:11 UTC by Andreas Nilsson
Modified: 2015-10-20 13:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot (131.14 KB, image/png)
2015-01-07 17:11 UTC, Andreas Nilsson
  Details
Patch to fix cairo rendering (2.12 KB, patch)
2015-01-09 17:58 UTC, Lubosz Sarnecki
none Details | Review

Description Andreas Nilsson 2015-01-07 17:11:41 UTC
Created attachment 294048 [details]
screenshot

The text that indicates the time is fuzzy on my laptop with a HiDPI display (3200x1800 on a 13")

Looks normal on my other laptop.
Comment 1 Jean-François Fortin Tam 2015-01-08 01:23:41 UTC
That's quite possible as the ruler portion is pure cairo, I don't think it has a notion of High DPI. I had already noticed this in bug #721614, which was more about "fundamentally broken" things (which Lubosz reports as working under GNOME 3.14 — is that your case too?) than details like fuzziness in the ruler.
Comment 2 Lubosz Sarnecki 2015-01-08 03:36:05 UTC
Can confirm that the labels on the ruler are not rendered in the correct resolution, but upscaled.

When you are using Windows 8.1 with HiDPI, you should be used to upscaled buffers ;)

Since we render the ruler ourselves in cairo, the buffer size should be changed accordingly for HiDPI and upscaling should be omitted.

It seems that GDK_SCALE upscales cairo buffers and does not render them in a native resolution.

This issue was already found by BrionVibber in 2013
https://wiki.gnome.org/BrionVibber/HiDpiNotes

This behavior needs likely to be fixed in cairo / GDK, but I didn't investigate further though. I also don't know how the application developer can influence cairo rendering on different GDK_SCALE settings.

Pitivi cannot be the only application with this problem.
Comment 3 Lubosz Sarnecki 2015-01-09 17:58:08 UTC
Created attachment 294173 [details] [review]
Patch to fix cairo rendering

I was wrong, this was our bug.
The cairo render code was weirdly duplicating cairo buffers for no reason. There is also confusion with Gtk widget.get_allocated_width()/height, which does not seem change, but the cairo buffer size changes. The coordinates in cairo need to be determined by the gtk w/h.
Also removing some cairo calls does not break the rendering for me. 

Can someone test this on HiDPI / LoDPI ?
Comment 4 Thibault Saunier 2015-10-20 13:20:48 UTC
This bug has been migrated to https://phabricator.freedesktop.org/T3270.

Please use the Phabricator interface to report further bugs by creating a task and associating it with Project: Pitivi.

See http://wiki.pitivi.org/wiki/Bug_reporting for details.