After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 739791 - v4l2bufferpool: unref pool when v4l2_allocator_new() fails
v4l2bufferpool: unref pool when v4l2_allocator_new() fails
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 1.4.5
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-11-07 15:51 UTC by Aurélien Zanelli
Modified: 2014-12-01 15:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
v4l2bufferpool: unref pool when v4l2_allocator_new() fails (741 bytes, patch)
2014-11-07 15:52 UTC, Aurélien Zanelli 		committed Details | Review

Description Aurélien Zanelli 2014-11-07 15:51:14 UTC 
In gst_v4l2_buffer_pool_new(), we don't unref pool if we can't create v4l2 allocator leading to a leak.
Comment 1 Aurélien Zanelli 2014-11-07 15:52:08 UTC 
Created attachment 290179 [details] [review]
v4l2bufferpool: unref pool when v4l2_allocator_new() fails
Comment 2 Nicolas Dufresne (ndufresne) 2014-12-01 15:07:00 UTC 
Review of attachment 290179 [details] [review]:

Yep, good catch.
Comment 3 Nicolas Dufresne (ndufresne) 2014-12-01 15:13:45 UTC 
Comment on attachment 290179 [details] [review]
v4l2bufferpool: unref pool when v4l2_allocator_new() fails

1.5
commit 74eb9037271cd6de848213f25168b6fe91b46ef5
Author: Aurélien Zanelli <aurelien.zanelli@parrot.com>
Date:   Fri Nov 7 16:41:52 2014 +0100

    v4l2bufferpool: unref pool when v4l2_allocator_new() fails
    
    https://bugzilla.gnome.org/show_bug.cgi?id=739791

And 1.4 commit 3aad797e2b69bcc413420bda69941e0c420ecd3e