GNOME Bugzilla – Bug 738056
In Orca preferences dialog the startup profile label not associated right with startup profile combo box
Last modified: 2014-12-05 13:03:51 UTC
Created attachment 287908 [details] Debug file Dear Joanie, In Orca preferences dialog/general page the startup profile label not associated right with startup profile related combo box. The accessibility section in the orca-setup.ui file filled correct, but Orca doesn't read the combobox related label (startup profile: text). Testcase: 1. Launch Orca, and activate preferences dialog. 2. With TAB or SHIFT+TAB keystrokes goto the startup profile related combo box. Expected result this situation: Orca need speak and present braille the "Startup profile:" label, the selected startup profile combobox item and combobox rolename. Actual result: me Orca presents only the default combobox list item and combobox rolename, both speech and braille output. My environment related informations: OS: Ubuntu 14.04 Orca version: latest master branch version Affected Orca branches: master, gnome-3-14 I attaching a debug.out file, next comment I attaching a short patch with resolve this bug. Attila
Created attachment 287909 [details] [review] Tested fix for this bug This patch me full resolve this bug. The fix method is trivial: The original orca-setup.ui file not filled the mnemonic_widget property with the availableProfilesComboBox2 object. If I apply this patch and repeat the wrote testcase, Orca correct speak and present braille the startup profile label when I land the startup profile combo box. Where am I command correct reporting too the combobox label. Please commit this patch both master and gnome-3-14 branches. Attila
Created attachment 287911 [details] The good working fix related debug.out file This debug.out shows Orca how read correct the startup profile related label when the caret lands the startup profile combo box. Attila
Comment on attachment 287909 [details] [review] Tested fix for this bug Thanks! Committed to both master and the gnome-3-14 branch.
Hi Joanie, Thanks the commit both two branches. I have got a question: The previous version before this commit only the accessibility section associated the startup profile label with the enableprofile2 combo box. Ideal the accessibility section related declaration not need handling this label association purpose? Have a known GTK3 bug with result this situation happening if not declared the mnemonic_widget property? Why need now declaring two place the label associations (the mnemonic_widget in main object part and the accessibility section) in the orca-setup.UI file? Usual when I creating dialogs with code level in Python3 I using only the mnemonic_widget property. In the UI file the accessibility section looks following, I very surprised this part not associate correct a label with a widget: <accessibility> <relation type="label-for" target="availableProfilesComboBox2"/> </accessibility> Attila
Hi Joanie, Sure committed the startup profile related fix the gnome-3-14 branch? In master branch following commit happened, with I not see the gnome-3-14 branch: commit 04595beb5e3939d2e9f6cfe80b1d35230aaecb2b Author: Attila Hammer <hammera@pickup.hu> Date: Tue Oct 7 07:48:09 2014 +0200 Fix for bug 738056 - The startup profile combo box is not properly labelled This fix doesn't landed the Orca 3.14.2 maintenance release. If this is need, please commit this fix the gnome-3-14 branch to this bugfix lands the future Orca 3.14.3 maintenance release. Attila
I thought I was sure. But, yes, you are correct. Sorry about that. Done now.
Hi Joanie, Yes, now correct committed the fix into gnome-3-14 branch. Landed the fix into Orca 3.14.3 release? I frayd not, because the commit happened after prep for the 3.14.3 release, and the Orca 3.14.3 tarrbal awailable src/orca/orca-setup.ui file not containing the fix. A little part from the UI file: <object class="GtkLabel" id="startupProfileLabel"> <property name="visible">True</property> <property name="can_focus">False</property> <property name="xalign">0</property> <property name="label" translatable="yes">Start-up Profile:</property> <accessibility> Before the accessibility part missing the mnemonic_widget property related line. Will be have a future Orca 3.14.4 maintenance release, or the 3.14.3 the last maintenance release of the 3.14 series? If will be have a 3.14.4 future maintenance release, I suggest an another commit with very missing from the 3.14 series: "commit 934ceff0ebd94fbec04117399466bed8f30354da Author: Joanmarie Diggs <jdiggs@igalia.com> Date: Fri Oct 17 14:23:52 2014 -0400 Work around the GNOME Shell issues related to switcher presentation Orca used to automatically present the selected item in a newly-shown switcher. It doesn't in GNOME 3.14. This is due to a couple of issues: * The ordering of accessible events has changed, so first we get the accessible event for the selected item. Then we get the one for the window activation. As a result, Orca ignores the selected item because it doesn't yet know the user is in a GNOME Shell window. (bgo738701) * The subsequent focused event for the containing panel, which does come after the window activation, should have be enough to cause Orca to automatically present the selected item even with the event ordering bug above. But this fails because Orca expects containers which contain selectable children to implement the accessible selection interface. GNOME Shell's switchers don't. (bgo738705) This commit hacks around the second issue and is sufficient to cause Orca to present the initially-selected item in a newly-shown switcher." This commit result more faster window switching when I using GNOME Shell. Attila