After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731443 - GtkPlacesSidebar - refine spacing
GtkPlacesSidebar - refine spacing
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
3.13.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
nautilus-next, 3.14
Depends on:
Blocks:
 
 
Reported: 2014-06-10 08:31 UTC by Allan Day
Modified: 2014-08-13 18:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
modified screenshot (375.01 KB, image/png)
2014-06-10 08:31 UTC, Allan Day
  Details
places-sidebar: Remove the separators and add more margin (4.09 KB, patch)
2014-06-18 21:24 UTC, Yosef Or Boczko
none Details | Review
places-sidebar: Remove the separators and add more margin (1.46 KB, patch)
2014-08-13 12:25 UTC, Yosef Or Boczko
none Details | Review

Description Allan Day 2014-06-10 08:31:24 UTC
Created attachment 278186 [details]
modified screenshot

During the 3.13.x cycle, the sub-headings were removed from GtkPlacesSidebar. This is good, and makes it much cleaner. However, the layout could still be improved, and there are a few small visual issues left by the change:

 * No padding between the top row and the top of the sidebar, which doesn't look great when the top item is selected.

 * With the headings gone, the list feels more visually constrained.

 * The lines which separate the groups add visual noise, and leave the groups seeming rather ambiguous - sections are delineated, but the user has to figure out what the lines mean.

I've attached a modified screenshot, which shows how these issues could be resolved. The original screenshot is on the left, and the modified version is on the right. Changes:

 * Add 4px padding above the top list item, to give it clearance from the top of the sidebar.

 * Increase the row height by 4px.

 * Remove the separators.
Comment 1 Yosef Or Boczko 2014-06-18 21:24:16 UTC
Created attachment 278718 [details] [review]
places-sidebar: Remove the separators and add more margin
Comment 2 Allan Day 2014-06-18 21:44:36 UTC
Looks good to me!
Comment 3 Yosef Or Boczko 2014-07-23 17:48:02 UTC
<mclasen> I don't like the outright removal of separators left and right
Comment 4 Allan Day 2014-08-13 12:15:25 UTC
(In reply to comment #3)
> <mclasen> I don't like the outright removal of separators left and right

Let's leave the separators in for now then.
Comment 5 Yosef Or Boczko 2014-08-13 12:25:57 UTC
Created attachment 283281 [details] [review]
places-sidebar: Remove the separators and add more margin