After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 730778 - Fix gtk-mac-integration support
Fix gtk-mac-integration support
Status: RESOLVED OBSOLETE
Product: glade
Classification: Applications
Component: general
3.8.x
Other Mac OS
: Normal normal
: ---
Assigned To: Glade 3 Maintainers
Glade 3 Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-05-27 00:23 UTC by Patrick Griffis (tingping)
Modified: 2018-03-26 15:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix gtk-mac-integration support (2.20 KB, patch)
2014-05-27 00:24 UTC, Patrick Griffis (tingping) 		needs-work Details | Review
[PATCH] MASTER - Fix gtk-mac-integration (2.77 KB, patch)
2014-06-25 22:29 UTC, Patrick Griffis (tingping) 		none Details | Review
[PATCH] GLADE-3-8 Fix gtk-mac-integration support (2.71 KB, patch)
2014-06-25 22:29 UTC, Patrick Griffis (tingping) 		none Details | Review

Description Patrick Griffis (tingping) 2014-05-27 00:23:25 UTC 
The api for gtk-mac-integration changed a while ago, it has been broken since.
Comment 1 Patrick Griffis (tingping) 2014-05-27 00:24:33 UTC 
Created attachment 277249 [details] [review]
Fix gtk-mac-integration support
Comment 2 Juan Pablo Ugarte 2014-05-27 17:32:15 UTC 
Review of attachment 277249 [details] [review]:

Sounds good to me, but I think we should add some version check in configure.ac to make sure we are using a package with the new API.

BTW should not we be using gtk-mac-integration-gtk2 and gtk-mac-integration-gtk3 instead of just gtk-mac-integration
At least this is what I get by taking a quick look at https://git.gnome.org/browse/gtk-mac-integration/tree/configure.ac

Also can you port this path to master?

thanks
Comment 3 Patrick Griffis (tingping) 2014-05-27 22:03:30 UTC 
>Sounds good to me, but I think we should add some version check in configure.ac
to make sure we are using a package with the new API.

Sounds like a really ugly solution. That version has been out for 4 years and nobody should be using that since JHBuild pulls in the latest.

>should not we be using gtk-mac-integration-gtk2 and
gtk-mac-integration-gtk3 instead of just gtk-mac-integration ... Also can you port this path to master?

I don't have a gtk3 build env set up on OSX atm (huge pita). So I can't test any rebase. But explicitly checking for gtk2 sounds fine.

My understanding is that 90% of what gtk-mac-integration does is built into Gtk3 now e.g. GtkApplication, GMenu. I have not used gtk3 glade on OSX but it should no longer need this.
Comment 4 Patrick Griffis (tingping) 2014-06-25 22:29:00 UTC 
Created attachment 279270 [details] [review]
[PATCH] MASTER - Fix gtk-mac-integration
Comment 5 Patrick Griffis (tingping) 2014-06-25 22:29:32 UTC 
Created attachment 279271 [details] [review]
[PATCH] GLADE-3-8 Fix gtk-mac-integration support
Comment 6 Patrick Griffis (tingping) 2014-06-25 22:31:20 UTC 
Rebased on master and does check for -gtk3/-gtk2 pkgconfig files.

Do note that it requires building gtk-mac-integration from git until they make another release though.
Comment 7 Tom Schoonjans 2015-06-15 09:28:40 UTC 
The latest release 2.0.8 of gtk-mac-integration is out now.

Would it be possible to release a new version of glade 3.8 that incorporates these proposed fixes?

Thanks
Comment 8 GNOME Infrastructure Team 2018-03-26 15:37:21 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/glade/issues/160.