After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 730109 - media: Make suspend()/unsuspend() virtual
media: Make suspend()/unsuspend() virtual
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-rtsp-server
git master
Other Linux
: Normal normal
: 1.3.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-05-14 07:40 UTC by Ognyan Tonchev (redstar_)
Modified: 2014-05-15 13:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
media: Make suspend()/unsuspend() virtual (8.23 KB, patch)
2014-05-14 07:40 UTC, Ognyan Tonchev (redstar_)
committed Details | Review

Description Ognyan Tonchev (redstar_) 2014-05-14 07:40:42 UTC
Created attachment 276512 [details] [review]
media: Make suspend()/unsuspend() virtual

This is a patch which makes media_suspend() and media_unsuspend() virtual. Please advise if this patch is acceptable.

The use case i am trying to solve: Checking for hardware resources plus enabling and configuring hardware whenever live medias are about to be prerolled. Reverse operation is done when pipeline is set to state GST_STATE_NULL.
503 SERVICE_UNAVAILABLE should be returned on failure.
The idea is to enable hardware from media_preroll(already virtual) and media_unsuspend and disable it from media_unpreroll(already virtual) and media_suspend.

Currently i am doing this from the media::target_state signal handler but it is not perfect since i am not able to return error.
Comment 1 Wim Taymans 2014-05-15 13:46:22 UTC
commit 0fb7922e9bcb6485fa5404412846685cae216e3a
Author: Ognyan Tonchev <ognyan@axis.com>
Date:   Wed May 14 09:31:31 2014 +0200

    media: Make suspend()/unsuspend() virtual
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=730109