After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 725612 - [review] add some logging functions to th/platform_link_logging
[review] add some logging functions to th/platform_link_logging
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-03-03 19:53 UTC by Thomas Haller
Modified: 2014-03-13 20:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Thomas Haller 2014-03-03 19:53:27 UTC 
while debugging something, I added a few to_string functions for netlink objects and for NMPlatformLink.

I don't feel strongly about them, they are not really used at the moment. But I think in general it's useful to be able to print our objects.

so, what do you think? Look at th/platform_link_logging
Comment 1 Dan Williams 2014-03-11 16:49:12 UTC 
Branch looks OK to me.
Comment 2 Jiri Klimes 2014-03-13 14:17:58 UTC 
I didn't find any issue in the code. Thanks for that, the enhanced debugging will certainly help us identifying potential problems.

Just a nit-picking:
> platform: extract function nm_platform_addr_flags2str() to wrap rtnl_addr_flags2str()
+	 * so, check for that.
+	 **/
Use only one star in the comment ending "*/".
Comment 3 Thomas Haller 2014-03-13 20:46:01 UTC 
(In reply to comment #2)
> Just a nit-picking:
> > platform: extract function nm_platform_addr_flags2str() to wrap rtnl_addr_flags2str()
> +     * so, check for that.
> +     **/
> Use only one star in the comment ending "*/".

changed.


Branch merged to master as http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=45a326d9c70f3b7235f6749186a6509de113ea72