After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 725364 - demos: Remove libraries from LDFLAGS
demos: Remove libraries from LDFLAGS
Product: libchamplain
Classification: Core
Component: General
Other All
: Normal normal
: ---
Assigned To: libchamplain-maint
Depends on:
Reported: 2014-02-28 04:21 UTC by Allison Karlitskaya (desrt)
Modified: 2014-03-03 20:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

demos: Remove libraries from LDFLAGS (916 bytes, patch)
2014-02-28 04:21 UTC, Allison Karlitskaya (desrt)
committed Details | Review

Description Allison Karlitskaya (desrt) 2014-02-28 04:21:23 UTC
The libraries that the demos link against are already (properly) listed
in the per-target _LDADD variable.  Libraries should never be in LDFLAGS
-- this is for linker options only.

This unbreaks the build on FreeBSD
Comment 1 Allison Karlitskaya (desrt) 2014-02-28 04:21:24 UTC
Created attachment 270536 [details] [review]
demos: Remove libraries from LDFLAGS
Comment 2 Jiri Techet 2014-03-03 20:22:00 UTC
Review of attachment 270536 [details] [review]:

Applied, thanks!