After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 724299 - Use Header Bars
Use Header Bars
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: general
3.11.x
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-02-13 14:58 UTC by Yosef Or Boczko
Modified: 2014-04-29 10:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
notifications: Use header bar in edit dialog (1.57 KB, patch)
2014-02-16 04:08 UTC, Yosef Or Boczko
needs-work Details | Review
search: Use header bar in the location dialog (2.57 KB, patch)
2014-02-16 04:08 UTC, Yosef Or Boczko
committed Details | Review
background: Use header bar in the chooser dialog (976 bytes, patch)
2014-02-16 04:08 UTC, Yosef Or Boczko
needs-work Details | Review
common: Use header bar in the language chooser dialog (3.42 KB, patch)
2014-02-16 04:09 UTC, Yosef Or Boczko
none Details | Review
datetime: Use header bar in the datetime and the timezone dialogs (8.94 KB, patch)
2014-02-16 04:09 UTC, Yosef Or Boczko
committed Details | Review
display: Use header bar in the dialogs (2.69 KB, patch)
2014-02-16 04:09 UTC, Yosef Or Boczko
needs-work Details | Review
info: Use header bar in the extra options dialog (2.87 KB, patch)
2014-02-16 04:09 UTC, Yosef Or Boczko
committed Details | Review
keyboard: Use header bar in the custom shortcut dialog (5.11 KB, patch)
2014-02-16 04:10 UTC, Yosef Or Boczko
needs-work Details | Review
mouse: Use header bar in the test settings dialog (1.65 KB, patch)
2014-02-16 04:10 UTC, Yosef Or Boczko
committed Details | Review
power: Use header bar in the automatic suspend dialog (3.28 KB, patch)
2014-02-16 04:10 UTC, Yosef Or Boczko
committed Details | Review
privacy: Use header bar in all the dialogs (21.29 KB, patch)
2014-02-16 04:10 UTC, Yosef Or Boczko
needs-work Details | Review
region: Use header bar in all the dialogs (8.43 KB, patch)
2014-02-16 04:11 UTC, Yosef Or Boczko
needs-work Details | Review
sharing: Use header bar in all the dialogs (10.62 KB, patch)
2014-02-16 04:11 UTC, Yosef Or Boczko
committed Details | Review
universal-access: Use header bar in all the dialogs (14.98 KB, patch)
2014-02-16 04:12 UTC, Yosef Or Boczko
needs-work Details | Review
universal-access: Use header bar in all the dialogs (3.61 KB, patch)
2014-02-16 04:12 UTC, Yosef Or Boczko
needs-work Details | Review
user-accounts: Use header bar in the account dialog (6.92 KB, patch)
2014-02-16 04:12 UTC, Yosef Or Boczko
none Details | Review
user-accounts: Use header bar in the password dialog (5.18 KB, patch)
2014-02-16 04:13 UTC, Yosef Or Boczko
none Details | Review
user-accounts: Use header bar in the photo dialog (1.28 KB, patch)
2014-02-16 04:13 UTC, Yosef Or Boczko
accepted-commit_now Details | Review
sound: Use header bar in the testing dialog (1.25 KB, patch)
2014-02-16 04:13 UTC, Yosef Or Boczko
needs-work Details | Review
user-accounts: Use header bar in the history dialog (9.03 KB, patch)
2014-02-16 04:13 UTC, Yosef Or Boczko
needs-work Details | Review
background: Use header bar in the chooser dialog (2.40 KB, patch)
2014-03-03 12:49 UTC, Yosef Or Boczko
committed Details | Review
keyboard: Use header bar in the custom shortcut dialog (5.11 KB, patch)
2014-03-03 12:49 UTC, Yosef Or Boczko
accepted-commit_now Details | Review
common: Use header bar in the language chooser dialog (2.14 KB, patch)
2014-03-03 12:49 UTC, Yosef Or Boczko
needs-work Details | Review
region: Use header bar in all the dialogs (7.00 KB, patch)
2014-03-03 12:50 UTC, Yosef Or Boczko
needs-work Details | Review
universal-access: Use header bar in all the dialogs (18.70 KB, patch)
2014-03-03 12:50 UTC, Yosef Or Boczko
needs-work Details | Review
notifications: Use header bar in the edit dialog (1.77 KB, patch)
2014-03-24 07:35 UTC, Yosef Or Boczko
committed Details | Review
display: Use header bar in the dialogs (2.69 KB, patch)
2014-03-24 07:36 UTC, Yosef Or Boczko
committed Details | Review
privacy: Use header bar in all the dialogs (20.91 KB, patch)
2014-03-24 07:36 UTC, Yosef Or Boczko
committed Details | Review
user-accounts: Use header bar in the photo dialog (1.09 KB, patch)
2014-03-24 07:36 UTC, Yosef Or Boczko
none Details | Review
sound: Use header bar in the testing dialog (1.76 KB, patch)
2014-03-24 07:37 UTC, Yosef Or Boczko
committed Details | Review
user-accounts: Use header bar in the history dialog (9.03 KB, patch)
2014-03-24 07:37 UTC, Yosef Or Boczko
committed Details | Review
common: Use header bar in the language chooser dialog (1.77 KB, patch)
2014-03-24 07:37 UTC, Yosef Or Boczko
committed Details | Review
region: Use header bar in all the dialogs (6.56 KB, patch)
2014-03-24 07:38 UTC, Yosef Or Boczko
committed Details | Review
universal-access: Use header bar in all the dialogs (18.56 KB, patch)
2014-03-24 07:38 UTC, Yosef Or Boczko
committed Details | Review
keyboard: Use header bar in the custom shortcut dialog (5.17 KB, patch)
2014-03-24 07:38 UTC, Yosef Or Boczko
committed Details | Review
user-accounts: Use header bar in the account dialog (6.93 KB, patch)
2014-03-26 06:38 UTC, Yosef Or Boczko
committed Details | Review
user-accounts: Use header bar in the password dialog (5.18 KB, patch)
2014-03-26 06:39 UTC, Yosef Or Boczko
committed Details | Review
user-accounts: Use header bar in the photo dialog (1.28 KB, patch)
2014-03-26 06:40 UTC, Yosef Or Boczko
committed Details | Review
user-accounts: Remove unused callback (1.23 KB, patch)
2014-04-28 16:37 UTC, Debarshi Ray
committed Details | Review

Description Yosef Or Boczko 2014-02-13 14:58:57 UTC
Some patches to enable using header bars in dialogs.
Comment 1 Matthias Clasen 2014-02-15 20:42:35 UTC
patches still coming ?
Comment 2 Yosef Or Boczko 2014-02-15 20:43:49 UTC
Oh, I forgot this, I'll uplade a patches in a hour.
Comment 3 Yosef Or Boczko 2014-02-16 04:08:11 UTC
Created attachment 269247 [details] [review]
notifications: Use header bar in edit dialog
Comment 4 Yosef Or Boczko 2014-02-16 04:08:28 UTC
Created attachment 269248 [details] [review]
search: Use header bar in the location dialog
Comment 5 Yosef Or Boczko 2014-02-16 04:08:46 UTC
Created attachment 269249 [details] [review]
background: Use header bar in the chooser dialog
Comment 6 Yosef Or Boczko 2014-02-16 04:09:01 UTC
Created attachment 269250 [details] [review]
common: Use header bar in the language chooser dialog
Comment 7 Yosef Or Boczko 2014-02-16 04:09:18 UTC
Created attachment 269251 [details] [review]
datetime: Use header bar in the datetime and the timezone dialogs
Comment 8 Yosef Or Boczko 2014-02-16 04:09:32 UTC
Created attachment 269252 [details] [review]
display: Use header bar in the dialogs
Comment 9 Yosef Or Boczko 2014-02-16 04:09:49 UTC
Created attachment 269253 [details] [review]
info: Use header bar in the extra options dialog
Comment 10 Yosef Or Boczko 2014-02-16 04:10:05 UTC
Created attachment 269254 [details] [review]
keyboard: Use header bar in the custom shortcut dialog
Comment 11 Yosef Or Boczko 2014-02-16 04:10:18 UTC
Created attachment 269255 [details] [review]
mouse: Use header bar in the test settings dialog
Comment 12 Yosef Or Boczko 2014-02-16 04:10:33 UTC
Created attachment 269256 [details] [review]
power: Use header bar in the automatic suspend dialog
Comment 13 Yosef Or Boczko 2014-02-16 04:10:51 UTC
Created attachment 269257 [details] [review]
privacy: Use header bar in all the dialogs
Comment 14 Yosef Or Boczko 2014-02-16 04:11:08 UTC
Created attachment 269258 [details] [review]
region: Use header bar in all the dialogs
Comment 15 Yosef Or Boczko 2014-02-16 04:11:23 UTC
Created attachment 269259 [details] [review]
sharing: Use header bar in all the dialogs
Comment 16 Yosef Or Boczko 2014-02-16 04:12:01 UTC
Created attachment 269260 [details] [review]
universal-access: Use header bar in all the dialogs
Comment 17 Yosef Or Boczko 2014-02-16 04:12:17 UTC
Created attachment 269261 [details] [review]
universal-access: Use header bar in all the dialogs
Comment 18 Yosef Or Boczko 2014-02-16 04:12:42 UTC
Created attachment 269262 [details] [review]
user-accounts: Use header bar in the account dialog
Comment 19 Yosef Or Boczko 2014-02-16 04:13:00 UTC
Created attachment 269263 [details] [review]
user-accounts: Use header bar in the password dialog
Comment 20 Yosef Or Boczko 2014-02-16 04:13:17 UTC
Created attachment 269264 [details] [review]
user-accounts: Use header bar in the photo dialog
Comment 21 Yosef Or Boczko 2014-02-16 04:13:37 UTC
Created attachment 269265 [details] [review]
sound: Use header bar in the testing dialog
Comment 22 Yosef Or Boczko 2014-02-16 04:13:58 UTC
Created attachment 269266 [details] [review]
user-accounts: Use header bar in the history dialog
Comment 23 Allan Day 2014-02-17 17:59:02 UTC
In general looks good. There are some bugs though:

region and language - language and formats dialogs should be presenation dialogs (just a close button), not action dialogs

background - stack switcher should be in the header bar, replacing the heading

keyboard - custom shortcut dialog - button should read "Add", not "Apply"

universal access - screen reader dialog - bottom of the dialog is cut off

universal access - visual alerts dialog - has a "close" button on the left. please move "Test Flash" to the left and use a regular X close button

users - login history - no close button is displayed. instead there is always a left and right arrow button

users - fingerprint login - there are a few oddities here (cancel button next to back, missing border around the list)

notifications - very tight padding around the content. needs to be at least 12px (this might not be a new bug - hard to tell)
Comment 24 Bastien Nocera 2014-02-18 07:41:32 UTC
Comment on attachment 269261 [details] [review]
universal-access: Use header bar in all the dialogs

The commit is wrong for this one.
Comment 25 Yosef Or Boczko 2014-03-03 12:49:12 UTC
Created attachment 270782 [details] [review]
background: Use header bar in the chooser dialog
Comment 26 Yosef Or Boczko 2014-03-03 12:49:37 UTC
Created attachment 270783 [details] [review]
keyboard: Use header bar in the custom shortcut dialog
Comment 27 Yosef Or Boczko 2014-03-03 12:49:57 UTC
Created attachment 270784 [details] [review]
common: Use header bar in the language chooser dialog
Comment 28 Yosef Or Boczko 2014-03-03 12:50:25 UTC
Created attachment 270785 [details] [review]
region: Use header bar in all the dialogs
Comment 29 Yosef Or Boczko 2014-03-03 12:50:48 UTC
Created attachment 270786 [details] [review]
universal-access: Use header bar in all the dialogs
Comment 30 Rui Matos 2014-03-13 15:25:46 UTC
Review of attachment 269247 [details] [review]:

::: panels/notifications/cc-edit-dialog.c
@@ +58,3 @@
   shell = GTK_WINDOW (gtk_widget_get_toplevel (GTK_WIDGET (panel)));
 
   win = GTK_DIALOG (gtk_dialog_new ());

This line needs to go
Comment 31 Rui Matos 2014-03-13 15:26:47 UTC
Review of attachment 269252 [details] [review]:

::: panels/display/cc-display-panel.c
@@ +1509,3 @@
   gtk_window_set_modal (GTK_WINDOW (priv->dialog), TRUE);
   gtk_dialog_add_button (GTK_DIALOG (priv->dialog), _("_Cancel"),
+                         GTK_RESPONSE_CANCEL);

Unrelated change, drop it please.

@@ +1952,3 @@
   gtk_window_set_modal (GTK_WINDOW (priv->dialog), TRUE);
   gtk_dialog_add_button (GTK_DIALOG (priv->dialog), _("_Cancel"),
+                         GTK_RESPONSE_CANCEL);

idem
Comment 32 Rui Matos 2014-03-13 16:33:01 UTC
Review of attachment 269257 [details] [review]:

::: panels/privacy/privacy.ui
@@ +126,3 @@
     <property name="resizable">False</property>
+    <property name="use_header_bar">1</property>
+    <child internal-child="headerbar">

This isn't needed
Comment 33 Rui Matos 2014-03-13 16:49:50 UTC
Review of attachment 269264 [details] [review]:

::: panels/user-accounts/um-photo-dialog.c
@@ +95,2 @@
                                               _("_Cancel"),
+                                              GTK_RESPONSE_CANCEL,

unrelated - please drop before pushing
Comment 34 Rui Matos 2014-03-13 17:01:11 UTC
Review of attachment 269265 [details] [review]:

::: panels/sound/gvc-mixer-dialog.c
@@ +1591,2 @@
         title = g_strdup_printf (_("Speaker Testing for %s"), gvc_mixer_ui_device_get_description (output));
         d = gtk_dialog_new_with_buttons (title,

If there are no buttons then gtk_dialog_new()
Comment 35 Rui Matos 2014-03-13 17:03:50 UTC
Review of attachment 269266 [details] [review]:

we can't remove the close button on this one
Comment 36 Rui Matos 2014-03-13 17:29:30 UTC
Review of attachment 270783 [details] [review]:

::: panels/keyboard/gnome-keyboard-panel.ui
@@ -43,3 @@
-                <property name="visible">True</property>
-                <property name="can_focus">True</property>
-                <property name="can_default">True</property>

Don't drop this, it causes a runtime warning.
Comment 37 Rui Matos 2014-03-13 17:38:31 UTC
Review of attachment 270784 [details] [review]:

::: panels/common/language-chooser.ui
@@ +8,3 @@
     <property name="resizable">False</property>
+    <property name="use_header_bar">1</property>
+    <child internal-child="headerbar">

None of this is needed
Comment 38 Rui Matos 2014-03-13 17:41:05 UTC
Review of attachment 270785 [details] [review]:

::: panels/region/format-chooser.ui
@@ +10,3 @@
     <property name="modal">True</property>
+    <property name="use_header_bar">1</property>
+    <child internal-child="headerbar">

No

::: panels/region/input-chooser.ui
@@ +13,3 @@
+        <property name="visible">True</property>
+        <property name="can_focus">False</property>
+        <property name="title" translatable="yes">Add an Input Source</property>

Don't repeat this please
Comment 39 Rui Matos 2014-03-13 17:45:12 UTC
Review of attachment 270786 [details] [review]:

::: panels/universal-access/uap.ui
@@ +779,3 @@
             <property name="margin_top">6</property>
             <property name="xalign">0</property>
+            <property name="max_width_chars">60</property>

unrelated, please drop

::: panels/universal-access/zoom-options.c
@@ -592,3 @@
-  w = WID ("closeButton");
-  g_signal_connect (G_OBJECT (w), "clicked",
-                    G_CALLBACK (zoom_option_close_dialog_cb),

Remove the function too as it's unused now
Comment 40 Rui Matos 2014-03-13 17:49:29 UTC
The ones I didn't mark look fine. This will need a UI/string freeze break exception to land.
Comment 41 Yosef Or Boczko 2014-03-13 21:42:00 UTC
Just a question - we can to see this in 3.12?
If it for 3.12 I'll find a time tomorrow to update all the
patches, but if it will land in 3.13/3.14 I'll do it later.
Comment 42 Yosef Or Boczko 2014-03-24 07:17:51 UTC
Review of attachment 269252 [details] [review]:

::: panels/display/cc-display-panel.c
@@ +1509,3 @@
   gtk_window_set_modal (GTK_WINDOW (priv->dialog), TRUE);
   gtk_dialog_add_button (GTK_DIALOG (priv->dialog), _("_Cancel"),
+                         GTK_RESPONSE_CANCEL);

This isn't right.
I needs to do this (to change to GTK_RESPONSE_CANCEL) if
I want to hide the close button, and to put the buttons in the
right place on the header bar.

Without this change, I have close button on the end, and also
two buttons at the end, "Cancel" and "Apply".
If I change to GTK_RESPONSE_CANCEL, I hvae only "Cancel" button
at the end, without close button, and "Apply" at the start of the header bar.

@@ +1952,3 @@
   gtk_window_set_modal (GTK_WINDOW (priv->dialog), TRUE);
   gtk_dialog_add_button (GTK_DIALOG (priv->dialog), _("_Cancel"),
+                         GTK_RESPONSE_CANCEL);

idem.
Comment 43 Yosef Or Boczko 2014-03-24 07:35:44 UTC
Created attachment 272732 [details] [review]
notifications: Use header bar in the edit dialog
Comment 44 Yosef Or Boczko 2014-03-24 07:36:05 UTC
Created attachment 272733 [details] [review]
display: Use header bar in the dialogs
Comment 45 Yosef Or Boczko 2014-03-24 07:36:26 UTC
Created attachment 272734 [details] [review]
privacy: Use header bar in all the dialogs
Comment 46 Yosef Or Boczko 2014-03-24 07:36:47 UTC
Created attachment 272735 [details] [review]
user-accounts: Use header bar in the photo dialog
Comment 47 Yosef Or Boczko 2014-03-24 07:37:03 UTC
Created attachment 272736 [details] [review]
sound: Use header bar in the testing dialog
Comment 48 Yosef Or Boczko 2014-03-24 07:37:31 UTC
Created attachment 272737 [details] [review]
user-accounts: Use header bar in the history dialog
Comment 49 Yosef Or Boczko 2014-03-24 07:37:46 UTC
Created attachment 272738 [details] [review]
common: Use header bar in the language chooser dialog
Comment 50 Yosef Or Boczko 2014-03-24 07:38:03 UTC
Created attachment 272739 [details] [review]
region: Use header bar in all the dialogs
Comment 51 Yosef Or Boczko 2014-03-24 07:38:24 UTC
Created attachment 272740 [details] [review]
universal-access: Use header bar in all the dialogs
Comment 52 Yosef Or Boczko 2014-03-24 07:38:43 UTC
Created attachment 272741 [details] [review]
keyboard: Use header bar in the custom shortcut dialog
Comment 53 Yosef Or Boczko 2014-03-26 06:38:33 UTC
Created attachment 272958 [details] [review]
user-accounts: Use header bar in the account dialog
Comment 54 Yosef Or Boczko 2014-03-26 06:39:03 UTC
Created attachment 272959 [details] [review]
user-accounts: Use header bar in the password dialog
Comment 55 Yosef Or Boczko 2014-03-26 06:40:44 UTC
Created attachment 272960 [details] [review]
user-accounts: Use header bar in the photo dialog

Same to comment #52, we needs to change to GTK_RESPONSE_CANCEL.
Comment 56 Yosef Or Boczko 2014-03-26 07:05:26 UTC
(In reply to comment #55)
> Created an attachment (id=272960) [details] [review]
> user-accounts: Use header bar in the photo dialog
> 
> Same to comment #52, we needs to change to GTK_RESPONSE_CANCEL.

Sorry, comment #42, not 52.
Comment 57 Yosef Or Boczko 2014-04-28 10:37:18 UTC
Ping (before 3.13.1).
Comment 58 Debarshi Ray 2014-04-28 16:37:23 UTC
Created attachment 275363 [details] [review]
user-accounts: Remove unused callback
Comment 59 Bastien Nocera 2014-04-29 09:22:14 UTC
Review of attachment 275363 [details] [review]:

Looks fine
Comment 60 Bastien Nocera 2014-04-29 10:19:47 UTC
Attachment 275363 [details] pushed as e168e2a - user-accounts: Remove unused callback