After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 723869 - GRAFCET shapes include an 'isspecial()' that conflicts with Darwin's ctype.h
GRAFCET shapes include an 'isspecial()' that conflicts with Darwin's ctype.h
Status: RESOLVED OBSOLETE
Product: dia
Classification: Other
Component: shapes
0.97.x
Other Mac OS
: Normal major
: ---
Assigned To: Dia maintainers
Dia maintainers
Depends on:
Blocks:
 
 
Reported: 2014-02-07 18:42 UTC by Kevin Ernst
Modified: 2019-03-20 12:00 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Only the relevant build output ('Making all in GRAFCET') (3.24 KB, text/plain)
2014-02-07 18:42 UTC, Kevin Ernst
  Details
Proposed patch renaming 'isspecial' to 'gb_isspecial' (503 bytes, patch)
2014-02-07 18:43 UTC, Kevin Ernst
none Details | Review

Description Kevin Ernst 2014-02-07 18:42:03 UTC
Created attachment 268442 [details]
Only the relevant build output ('Making all in GRAFCET')

The relevant Darwin/OS X source file is:

http://www.opensource.apple.com/source/Libc/Libc-262/include/ctype.h


Renaming 'isspecial' in GRAFCET's boolequation.c corrects the problem, and I've attached a hopefully well-formed patch file against <src>/objects/GRAFCET/boolequation.c that should fix the problem.

This may be the second patch I've ever submitted (to any FLOSS project, ever), so please do pardon if in simply renaming a conflicting function with a prefix (I chose 'gb_' for the 'gboolean' return type of this function), I've committed some breach of protocol.
Comment 1 Kevin Ernst 2014-02-07 18:43:46 UTC
Created attachment 268443 [details] [review]
Proposed patch renaming 'isspecial' to 'gb_isspecial'
Comment 2 Hans Breuer 2014-02-08 17:09:12 UTC
The declaration is protected by
#if !defined(_ANSI_SOURCE) && !defined(_POSIX_SOURCE)
so rather than modifying Dia's source for the namespace pollution it should be checked why it works for me, but not for you.
I wonder if this due to a newer or older system. Could you give the output of gcc --version?
Comment 3 Hans Breuer 2014-03-02 09:59:28 UTC
The build flags were recently changed (e.g. no more --std=c89). Still no clue what build environment difference could cause the issue.
Comment 4 GNOME Infrastructure Team 2019-03-20 12:00:09 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/dia/issues/335.