After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 723354 - Ignore SASL handler invalidated while preparing them
Ignore SASL handler invalidated while preparing them
Status: RESOLVED OBSOLETE
Product: empathy
Classification: Core
Component: Auth client
unspecified
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2014-01-31 11:07 UTC by Guillaume Desmottes
Modified: 2018-05-22 16:24 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
add empathy_server_sasl_handler_is_valid() (1.51 KB, patch)
2014-01-31 11:14 UTC, Guillaume Desmottes
none Details | Review
auth-factory: ignore SASL handler which have been invalidated while creating them (1.41 KB, patch)
2014-01-31 11:14 UTC, Guillaume Desmottes
none Details | Review
empathy_server_sasl_handler_new_finish: check if proxy has been invalidated (1.57 KB, patch)
2014-02-03 10:51 UTC, Guillaume Desmottes
none Details | Review

Description Guillaume Desmottes 2014-01-31 11:07:02 UTC
While testing the next branch, it happened that sometimes the SASL handler was invalidated while preparing it (gnome-keyring failing because of my test setup but that's not really the point). We were still trying to use this invalidated handler resulting in warnings.
Comment 1 Guillaume Desmottes 2014-01-31 11:14:16 UTC
Created attachment 267715 [details] [review]
add empathy_server_sasl_handler_is_valid()
Comment 2 Guillaume Desmottes 2014-01-31 11:14:26 UTC
Created attachment 267716 [details] [review]
auth-factory: ignore SASL handler which have been invalidated while creating them

The user of the auth-factory will connect to the 'invalidated' signal to stop
processing if the handler get invalidated. But it will never receive this
signal if it has been fired *before* we announce the handler to it.

Just discard those handlers in the factory as we can't do much with them
anyway.
Comment 3 Guillaume Desmottes 2014-02-03 10:51:00 UTC
From IRC:

 <xclaesse> cassidy, hm, I would expect empathy_server_sasl_handler_new_finish() to give an error in that case
Comment 4 Guillaume Desmottes 2014-02-03 10:51:11 UTC
Created attachment 267937 [details] [review]
empathy_server_sasl_handler_new_finish: check if proxy has been invalidated
Comment 5 GNOME Infrastructure Team 2018-05-22 16:24:14 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/empathy/issues/760.