GNOME Bugzilla – Bug 723354
Ignore SASL handler invalidated while preparing them
Last modified: 2018-05-22 16:24:14 UTC
While testing the next branch, it happened that sometimes the SASL handler was invalidated while preparing it (gnome-keyring failing because of my test setup but that's not really the point). We were still trying to use this invalidated handler resulting in warnings.
Created attachment 267715 [details] [review] add empathy_server_sasl_handler_is_valid()
Created attachment 267716 [details] [review] auth-factory: ignore SASL handler which have been invalidated while creating them The user of the auth-factory will connect to the 'invalidated' signal to stop processing if the handler get invalidated. But it will never receive this signal if it has been fired *before* we announce the handler to it. Just discard those handlers in the factory as we can't do much with them anyway.
From IRC: <xclaesse> cassidy, hm, I would expect empathy_server_sasl_handler_new_finish() to give an error in that case
Created attachment 267937 [details] [review] empathy_server_sasl_handler_new_finish: check if proxy has been invalidated
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/empathy/issues/760.