After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 721733 - Tweak Berkeley DB detection logic
Tweak Berkeley DB detection logic
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: general
3.11.x (obsolete)
Other All
: Normal normal
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2014-01-07 21:12 UTC by Allison Karlitskaya (desrt)
Modified: 2014-01-08 15:13 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
build: tweak Berkeley DB detection logic (1.51 KB, patch)
2014-01-07 21:12 UTC, Allison Karlitskaya (desrt)
none Details | Review
build: tweak Berkeley DB detection logic (1.51 KB, patch)
2014-01-07 21:21 UTC, Allison Karlitskaya (desrt)
committed Details | Review

Description Allison Karlitskaya (desrt) 2014-01-07 21:12:53 UTC
Make two changes to the logic that we use to find the Berkeley DB:

 - in the default case where --with-libdb is not given, do not attempt
   to add the default ${prefix}/include and ${prefix}/lib to the CFLAGS
   and LIBS.  Only do this if --with-libdb is explicitly given.

 - in the case where --with-libdb is not given, and DB_CFLAGS or DB_LIBS
   is already set, use those values instead of our own guesses

This allows the build to proceed on FreeBSD, where the headers are in an
unusual location and the library has an unusual name.
Comment 1 Allison Karlitskaya (desrt) 2014-01-07 21:12:54 UTC
Created attachment 265580 [details] [review]
build: tweak Berkeley DB detection logic
Comment 2 Allison Karlitskaya (desrt) 2014-01-07 21:21:10 UTC
Created attachment 265587 [details] [review]
build: tweak Berkeley DB detection logic

Fix a pair of really silly typos discovered during testing.
Comment 3 Matthew Barnes 2014-01-08 15:12:23 UTC
Thanks!  The --with-libdb configure option has always been rather awkward.  I think this helps simplify it.

Worth noting that Evolution-Data-Server doesn't actually use Berkeley DB anymore, but we still link to it to migrate old address book databases to SQLite.

Committed for 3.11.4 in:
https://git.gnome.org/browse/evolution-data-server/commit/?id=3bb0c0e98965387dfaac8cdc14e7347217e6f68e