After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 721700 - invalid callback prototypes leads to test issues
invalid callback prototypes leads to test issues
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Class: GtkBuilder
3.10.x
Other Linux
: Normal normal
: ---
Assigned To: GtkBuilder maintainers
GtkBuilder maintainers
Depends on:
Blocks:
 
 
Reported: 2014-01-07 12:59 UTC by Sebastien Bacher
Modified: 2014-01-08 09:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
that patch fixes the issue, thanks Steve Langasek (3.86 KB, patch)
2014-01-07 12:59 UTC, Sebastien Bacher 		committed Details | Review

Description Sebastien Bacher 2014-01-07 12:59:48 UTC 
Created attachment 265533 [details] [review]
that patch fixes the issue, thanks Steve Langasek

The bug has been reported on https://bugs.launchpad.net/ubuntu/+source/gtk+3.0/+bug/1262380

"gtk+3.0 fails to build on ppc64el with a test suite failure in the gtkbuilder tests:
...
 The signal callbacks are defined to take pointers as their arguments, but the
 callbacks found in testsuite/gtk/builder.c are passing a GParamSpec by value
 as the second argument.  This confuses and angers the compiler on ppc64el,
 resulting in segfaults after return from the function due to stack-smashing
 by the (completely-unused) argument."
Comment 1 Tristan Van Berkom 2014-01-07 13:18:31 UTC 
Review of attachment 265533 [details] [review]:

Patch looks completely reasonable to me.
Comment 2 Matthias Clasen 2014-01-07 13:40:09 UTC 
Review of attachment 265533 [details] [review]:

That confuses and angers me too! Please commit
Comment 3 Sebastien Bacher 2014-01-08 09:48:05 UTC 
Thanks, commited to trunk and gtk-3-10