After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 721158 - Missing ICU string when doing --version on xmllint
Missing ICU string when doing --version on xmllint
Status: RESOLVED FIXED
Product: libxml2
Classification: Platform
Component: general
git master
Other All
: Normal minor
: ---
Assigned To: Daniel Veillard
libxml QA maintainers
Depends on:
Blocks:
 
 
Reported: 2013-12-28 15:59 UTC by milo
Modified: 2016-04-29 18:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed Patch v1 (1.09 KB, patch)
2016-03-02 20:53 UTC, David Kilzer
none Details | Review

Description milo 2013-12-28 15:59:46 UTC
hi.

on line 2964 of xmllint.c there shoud be something like this:

    if (xmlHasFeature(XML_WITH_ZLIB)) fprintf(stderr, "Zlib ");
+    if (xmlHasFeature(XML_WITH_ICU)) fprintf(stderr, "ICU ");
    if (xmlHasFeature(XML_WITH_LZMA)) fprintf(stderr, "Lzma ");

so: if icu is enabled it is shown as a feature in --version command
Comment 1 David Kilzer 2016-03-02 20:53:31 UTC
Created attachment 322919 [details] [review]
Proposed Patch v1
Comment 2 David Kilzer 2016-03-02 20:55:30 UTC
(In reply to David Kilzer from comment #1)
> Created attachment 322919 [details] [review] [review]
> Proposed Patch v1

Since Iconv and ICU are mutually exclusive, I placed the XML_WITH_ICU check just below the XML_WIT_ICONV check.
Comment 3 David Kilzer 2016-04-29 17:31:51 UTC
This was fixed in 783931fc5928cfcfaeb2e3199203e3c3fe7d75ec.

<https://git.gnome.org/browse/libxml2/commit/?id=783931fc5928cfcfaeb2e3199203e3c3fe7d75ec>

I can't move it to RESOLVED/FIXED because I don't have editbugs permission for GNOME Bugzilla.