After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 720884 - glade-editor-property: use literal format strings
glade-editor-property: use literal format strings
Status: RESOLVED FIXED
Product: glade
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Glade 3 Maintainers
Glade 3 Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-12-21 16:07 UTC by Allison Karlitskaya (desrt)
Modified: 2013-12-21 20:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
glade-editor-property: use literal format strings (3.43 KB, patch)
2013-12-21 16:07 UTC, Allison Karlitskaya (desrt) 		none Details | Review

Description Allison Karlitskaya (desrt) 2013-12-21 16:07:15 UTC 
I'm pretty sure the patch here is correct in terms of keeping
functionality with the original, but the original was pretty difficult
to understand.  I didn't test it.
Comment 1 Allison Karlitskaya (desrt) 2013-12-21 16:07:16 UTC 
Created attachment 264693 [details] [review]
glade-editor-property: use literal format strings

Refactor glade_eprop_object_dialog_title() to make use of literal format
strings instead of storing the format string into a variable.

It is my opinion that this change also improves readability of the
function in question by reducing the complexity and redundancy of the
checks.

This fixes the build which was broken on clang due to the use of
-Werror=format-nonliteral.
Comment 2 Juan Pablo Ugarte 2013-12-21 20:38:34 UTC 
You can test this function for example with transient-for and accelerator-group properties in a GtkWindow.

pushed to master