GNOME Bugzilla – Bug 720883
gladeui: fix a pair of printf security problems
Last modified: 2013-12-21 20:34:21 UTC
Looks like clang's pedantic treatment of format strings actually turned up a real bug for a change... two, in fact.
Created attachment 264692 [details] [review] gladeui: fix a pair of printf security problems In two cases, gladeui was doing the equivalent of printf (var); instead of the correct (and safe): printf ("%s", var); This was caught by clang's pedantic treatment of non-literal format strings forcing me to add G_GNUC_PRINTF attributes to functions operating on format strings (which in turn caught the problem). Those changes are also included here.
Good catch, pushed in master