After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 720386 - gdbusproxy prefixes unstripped error
gdbusproxy prefixes unstripped error
Status: RESOLVED OBSOLETE
Product: glib
Classification: Platform
Component: gdbus
unspecified
Other Linux
: Normal minor
: ---
Assigned To: David Zeuthen (not reading bugmail)
gtkdev
Depends on:
Blocks:
 
 
Reported: 2013-12-13 12:20 UTC by Christian Persch
Modified: 2018-05-24 16:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gdbus: proxy: Strip remote error on activation failure (834 bytes, patch)
2013-12-13 12:24 UTC, Christian Persch 		none Details | Review
gdbus: proxy: Strip remote error on activation failure (834 bytes, patch)
2013-12-13 12:27 UTC, Christian Persch 		accepted-commit_now Details | Review

Description Christian Persch 2013-12-13 12:20:28 UTC 
When you construct a gdbus proxy for a service that is autostarted by that construction, but the server fails to start (e.g. by just calling exit()), the returned GError says:

Error constructing proxy for 
org.gnome.Terminal:/org/gnome/Terminal/Factory0: Error calling 
StartServiceByName for org.gnome.Terminal: 
GDBus.Error:org.freedesktop.DBus.Error.Spawn.ChildExited: Process 
/usr/lib/gnome-terminal/gnome-terminal-server exited with status 1

Note the presence of the GDBus.Error: prefix of the inner error. I think that prefix should be stripped; attached patch does so.
Comment 1 Christian Persch 2013-12-13 12:24:49 UTC 
Created attachment 264136 [details] [review]
gdbus: proxy: Strip remote error on activation failure
Comment 2 Christian Persch 2013-12-13 12:27:44 UTC 
Created attachment 264138 [details] [review]
gdbus: proxy: Strip remote error on activation failure
Comment 3 Allison Karlitskaya (desrt) 2013-12-13 14:34:44 UTC 
Where did the "GDBus.Error" come from?
Comment 4 Christian Persch 2013-12-13 14:49:46 UTC 
Hmm? That's added by gdbus, at gio/gdbuserror.c:g_dbus_error_new_for_dbus_error().
Comment 5 Colin Walters 2016-11-22 19:58:15 UTC 
Review of attachment 264138 [details] [review]:

Sure.
Comment 6 GNOME Infrastructure Team 2018-05-24 16:09:53 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/glib/issues/804.