GNOME Bugzilla – Bug 719186
If Trash is unavailable, RAW files are not deleted from RAW+JPEG pairs
Last modified: 2017-08-31 08:49:46 UTC
---- Reported by firstname.lastname@example.org 2013-08-07 01:36:00 -0700 ----
Original Redmine bug id: 7310
Original URL: http://redmine.yorba.org/issues/7310
Searchable id: yorba-bug-7310
Original author: Michał Sawicz
If Trash is unavailable for some reason (e.g. external volume whose root isn't
writable by the user) and you delete a RAW+JPEG photo, Shotwell correctly
reports that it can't move to Trash and will delete directly, but the RAW file
related to shotwell - Feature #7311: Shotwell's Trash shouldn't be
disconnected from system's ... (Duplicate)
related to shotwell - 4207: RAW files in RAW+JPEG pairs aren't properly
---- Additional Comments From email@example.com 2013-08-07 13:51:00 -0700 ----
Updated by Jim Nelson 4 months ago
Reported at https://bugs.launchpad.net/ubuntu/+source/shotwell/+bug/1201558
--- Bug imported by firstname.lastname@example.org 2013-11-25 22:00 UTC ---
This bug was previously known as _bug_ 7310 at http://redmine.yorba.org/show_bug.cgi?id=7310
Unknown version " in product shotwell.
Setting version to "!unspecified".
Unknown milestone "unknown in product shotwell.
Setting to default milestone for this product, "---".
Setting qa contact to the default for this product.
This bug either had no qa contact or an invalid one.
Resolution set on an open status.
Created attachment 356395 [details]
Completed "delete_backing_files", to delete RAW-files, too.
I fixed this BUG. The described problem was caused by the incomplete function "delete_backing_files" (see this attachment) in "MediaDataRepresentation.vala".
I just had to add the deletion of the master file (the raw file).
I hope that I could help.
Created attachment 356399 [details] [review]
Diff generated from file
Review of attachment 356399 [details] [review]:
@@ +176,3 @@
+ return prepare_input_text(filename,
+ PrepareInputTextOptions.DEFAULT & ~PrepareInputTextOptions.STRIP, DEFAULT_USER_TEXT_INPUT_LENGTH);
This looks unrelated
@@ +791,2 @@
Please do not remove the copy function selection function. This is necessary for fixing the issue of not being able to copy files on NTFS-backed filesystems.
Created attachment 358613 [details] [review]
When Trash is not available, also remove RAW file
Attachment 358613 [details] pushed as 012a1ca - When Trash is not available, also remove RAW file