After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 712796 - videodecoder: incorrect timestamps sequence
videodecoder: incorrect timestamps sequence
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 1.2.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-11-21 11:01 UTC by Oleksij Rempel
Modified: 2013-11-26 11:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
videodecoder: avoid descending output timestamps (930 bytes, patch)
2013-11-21 20:37 UTC, Mark Nauwelaerts
committed Details | Review

Description Oleksij Rempel 2013-11-21 11:01:15 UTC
Some dvds have probably bugs which cause incorrect timestamps sequence. For example 887266666 then 847266666.
It is not a problem if you play it. But it will cause problems if you convert it to vp8/mkv.

This is probably reason for Bug 712219

sample file is here:
https://www.dropbox.com/s/4zlkvnt2igf9a2z/bug_timestamp.mpeg

you can catch brocken timestamps with this command:
gst-launch-1.0 -vm filesrc location=bug_timestamp.mpeg ! mpegpsdemux ! mpegvideoparse ! identity check-imperfect-timestamp=1 ! fakesink silent=1 | grep ident
Comment 1 Oleksij Rempel 2013-11-21 11:58:37 UTC
Same issue on other dvd. Probably some timestamp is extracted incorrectly.
Comment 2 Mark Nauwelaerts 2013-11-21 20:37:10 UTC
Created attachment 261116 [details] [review]
videodecoder: avoid descending output timestamps

This should fix this and avoid some weird timestamps, though it may/will still not lead to a perfect stream.  The latter makes sense this is not necessarily a perfect fix/solution in various ways, but there is quite some timestamp guestimating heuristic happening in videodecoder trying to suit all possible cases, and this seems about as much tweaking as is possible/advisable (also in view of no problems at playback).  Other suggestions of course still welcome.
Comment 3 Oleksij Rempel 2013-11-22 10:04:41 UTC
Hi, thank you for the patch.
it make timestamp look less wired :)

Suddenly it wont fix Bug 712219, so it is probably unrelated to this issue.
Comment 4 Mark Nauwelaerts 2013-11-23 18:41:16 UTC
commit ee86a91957b73e57c1d9b540c53b21e0fc49def4
Author: Mark Nauwelaerts <mnauw@users.sourceforge.net>
Date:   Thu Nov 21 21:33:59 2013 +0100

    videodecoder: avoid descending output timestamps
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=712796