Looks interesting. Do you know if they offer some access to the map tiles? (My German is limited and was a little lazy to browse the web page for more info.) If so, there should be no problem to add the support to libchamplain.

Actually the site is in English too. There is a language bar on top of the page. 

At least OpenCPN can use those tiles, but I'm not sure, if you have to download them manually. I'm sure, many in the OpenSeaMap development team understand English.

Created attachment 323839 [details] [review]
Add OpenSeaMap Source

Add OpenSeaMap tile source which contains sea markers
over a transparent background

Hmm, does it show anything for you? I get just empty map with your patch.

I am sorry for pushing the patch without proper testing.

The map is not showing, but I have checked the tile server which provides the tiles in png format which contains the sea markers. I will look into it.

Do you have any idea why is this happening?

(In reply to Nayan Deshmukh from comment #5)
> I am sorry for pushing the patch without proper testing.
> 
> The map is not showing, but I have checked the tile server which provides
> the tiles in png format which contains the sea markers. I will look into it.
> 
> Do you have any idea why is this happening?


Who has requested the need for openseamap integration? I do not know if libchamplain should add map sources just because they are there.

http://tiles.openseamap.org/seamark/9/13/128.png

It seems to be working, but I am guessing not all tiles will have a mark, and I do not know exactly what these marks are, do you?


http://wiki.openseamap.org/wiki/OpenSeaMap-dev:Server
^^^
According to that there are several different openseamap tile servers which seem to have different information. Why did you choose the semark one?

(In reply to Jonas Danielsson from comment #6)
> (In reply to Nayan Deshmukh from comment #5)
> > I am sorry for pushing the patch without proper testing.
> > 
> > The map is not showing, but I have checked the tile server which provides
> > the tiles in png format which contains the sea markers. I will look into it.
> > 
> > Do you have any idea why is this happening?
> 
> 
> Who has requested the need for openseamap integration? I do not know if
> libchamplain should add map sources just because they are there.

Jiri was interested in it so I thought that maybe I could implement it.
 
> http://tiles.openseamap.org/seamark/9/13/128.png
> 
> It seems to be working, but I am guessing not all tiles will have a mark,
> and I do not know exactly what these marks are, do you?

These are nautical charts. Charts will show lighthouses, lateral buoy, cardinal marks and other navigational aids. In the ports, facilities will be mapped (port wall, pier, walkways, docks, fueling stations, loading cranes, access roads, railway lines, ferry lines). Similarly, public authorities, shipbuilders and repairers, as well as sanitation and utility facilities will be displayed. The navigational attributes correspond to the international standard IHO S-57.
 

> http://wiki.openseamap.org/wiki/OpenSeaMap-dev:Server
> ^^^

Created attachment 323949 [details] [review]
Add OpenSeaMap Source

Add OpenSeaMap tile source which contains sea markers
over a transparent background

Jiri I have tested the above patch and it shows only the markers and not the map.

Do you think we need to add sources like open sea map and other such sources?
It will increase the features in libchamplain and make it useful in different apps.

Thanks Nayan, seems to work now. The question raised by Jonas is right though - are the marks something useful for a wide-enough audience? 

(Maybe they are, I don't know, I'm from a country without any see and basically my knowledge about the see is it consists of salt water, there are various creatures swimming in it and the transport vehicle used there is called a ship :-).

I agree with you Jiri this patch does not target much wider audience so may be we should not include it.

-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/libchamplain/issues/22.