After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 711583 - NautilusFile: fix crash in modify_link_hash_table
NautilusFile: fix crash in modify_link_hash_table
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Crashers
3.10.x
Other Linux
: Normal critical
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-11-07 04:11 UTC by Michael Catanzaro
Modified: 2013-11-24 23:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
NautilusFile: fix crash in modify_link_hash_table (1.05 KB, patch)
2013-11-07 04:11 UTC, Michael Catanzaro 		committed Details | Review

Description Michael Catanzaro 2013-11-07 04:11:52 UTC 
For some reason when connecting to my school's network storage via sftp, gio returns a file that is not a symlink but has the symlink_name property set (to "/"). This causes a crash in modify_link_hash_table, which assumes that if it has a symlink_name it must be a symlink.

I guess this is clearly a bug in gio, which I'm still investigating, but it'd be nice to not crash.
Comment 1 Michael Catanzaro 2013-11-07 04:11:54 UTC 
Created attachment 259157 [details] [review]
NautilusFile: fix crash in modify_link_hash_table

We crash in g_hash_table_lookup_extended if the file's symlink_name is
set but the file is not a symlink, since the hash function (g_str_hash)
does not allow NULL values but target_uri is NULL.
Comment 2 Michael Catanzaro 2013-11-07 05:16:18 UTC 
(In reply to comment #0)
> has the symlink_name property set (to "/").
That was inaccurate.  Each file has the symlink_name set to itself. This is a Microsoft DFS; that's all I know.
Comment 3 Michael Catanzaro 2013-11-24 23:55:55 UTC 
Attachment 259157 [details] pushed as c2a5e05 - NautilusFile: fix crash in modify_link_hash_table