After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 711308 - Some fixes for the save confirmation dialog
Some fixes for the save confirmation dialog
Status: RESOLVED OBSOLETE
Product: glade
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Glade 3 Maintainers
Glade 3 Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-11-02 19:55 UTC by William Jon McCann
Modified: 2018-03-26 15:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix display of save error details (1.59 KB, patch)
2013-11-02 19:55 UTC, William Jon McCann
needs-work Details | Review
Use Cancel/Save buttons in save confirmation dialog (2.61 KB, patch)
2013-11-02 19:55 UTC, William Jon McCann
needs-work Details | Review
Align details window with action buttons (963 bytes, patch)
2013-11-02 19:55 UTC, William Jon McCann
accepted-commit_now Details | Review
Use proper quotes in save confirmation message (1.15 KB, patch)
2013-11-02 19:55 UTC, William Jon McCann
reviewed Details | Review
Don't use markup in the message dialog labels (775 bytes, patch)
2013-11-02 19:55 UTC, William Jon McCann
needs-work Details | Review
screenshot (before) (19.90 KB, image/png)
2013-11-02 19:58 UTC, William Jon McCann
  Details

Description William Jon McCann 2013-11-02 19:55:03 UTC
Here are a few patches for the save confirmation dialog.
Comment 1 William Jon McCann 2013-11-02 19:55:05 UTC
Created attachment 258819 [details] [review]
Fix display of save error details

Make sure we show enough height in the scrolled window and correctly
set the scroll policy.
Comment 2 William Jon McCann 2013-11-02 19:55:08 UTC
Created attachment 258820 [details] [review]
Use Cancel/Save buttons in save confirmation dialog

Instead of Yes/No as recommended by the HIG.
Comment 3 William Jon McCann 2013-11-02 19:55:11 UTC
Created attachment 258821 [details] [review]
Align details window with action buttons
Comment 4 William Jon McCann 2013-11-02 19:55:14 UTC
Created attachment 258822 [details] [review]
Use proper quotes in save confirmation message
Comment 5 William Jon McCann 2013-11-02 19:55:16 UTC
Created attachment 258823 [details] [review]
Don't use markup in the message dialog labels

This allows the dialog to use the default bold style.
Comment 6 William Jon McCann 2013-11-02 19:58:53 UTC
Created attachment 258824 [details]
screenshot (before)
Comment 7 Juan Pablo Ugarte 2013-11-03 00:21:40 UTC
Thanks Jon, I will take a look at this ASAP

BTW does this qualify as a UI break?
Comment 8 Tristan Van Berkom 2013-11-06 05:01:54 UTC
Review of attachment 258819 [details] [review]:

This patch causes the error window in the save confirmation dialog to not scroll horizontally and wrap instead.

That is a problem, this error message should definitely not wrap in the way it's currently formatted.

Each line is a warning message pertaining to a specific widget, property or signal, and each line is prefixed with the full path to that element on the same line.

The path is generated with glade_widget_generate_path_name() and for a deep widget it can be pretty long... wrapping text in there will just cause mayhem.

I'm totally open to a change that actually improves this though, one thought is that since warnings now show up with icons and warnings in the inspector, we could show the inspector treeview in the scrolled window with the rows filtered down to only objects which have errors (and their parents of course, so one can still see the tree).
Comment 9 Tristan Van Berkom 2013-11-06 05:05:41 UTC
Review of attachment 258820 [details] [review]:

Looks good.

Please make the same change you did for gladeui/glade-project.c also in src/glade-window.c

In do_save(), where it asks "Failed to backup existing file, continue saving ?".

And then commit.
Comment 10 Tristan Van Berkom 2013-11-06 05:07:21 UTC
Review of attachment 258821 [details] [review]:

Correct, the child of the dialogs content "vbox" must have a border width of 5, ugly but true ;-)
Comment 11 Tristan Van Berkom 2013-11-06 05:16:41 UTC
Review of attachment 258822 [details] [review]:

Why the fancy quote characters ?

Is it wise to apply this to projects directly as a hard coded utf-8 character ?

Not better to push for a set of well defined macros in some gnome common package first ?
GNOME_ELLIPSES, GNOME_CUTE_QUOTE_START, GNOME_CUTE_QUOTE_END ?

By the looks of it, you already missed over 90% of the instances where quotes are
used and displayed in warnings and dialogs... that must be an indication that
we're going about enforcing UI consistency in the wrong way.

I.e. consult:

  grep -r -i "\\\\\\\"" `find . -name "*.c"`

(yeah looks weird... through bash & grep you need a lot of back slashes to match: \")
Comment 12 Tristan Van Berkom 2013-11-06 05:23:41 UTC
Review of attachment 258823 [details] [review]:

Since GTK+ API is completely awkward in this regard, I'd rather you add a comment around that.

Calling gtk_message_dialog_set_markup() followed by g_object_set (dialog, "use-markup", FALSE, NULL);
screams at me... saying:
   "Tristan you silly bastard, why arent you just calling gtk_message_dialog_set_text() ?"

Would be great to have a comment pointing an accusing finger at GtkMessageDialog API along with that... then please commit ;-)
Comment 13 William Jon McCann 2014-10-22 15:39:35 UTC
(In reply to comment #9)
> Review of attachment 258820 [details] [review]:
> 
> Looks good.
> 
> Please make the same change you did for gladeui/glade-project.c also in
> src/glade-window.c
> 
> In do_save(), where it asks "Failed to backup existing file, continue saving
> ?".
> 
> And then commit.

For the GLADE_UI_ARE_YOU_SURE dialog? Those seem to have OK/Cancel and not Yes/No I think.
Comment 14 gkrithi8 2017-11-24 05:56:52 UTC
Currently, I do a copy / paste of the error message to emacs and format it via macros, to have a good look of the warnings. Thanks !
Comment 15 GNOME Infrastructure Team 2018-03-26 15:32:44 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/glade/issues/142.