GNOME Bugzilla – Bug 711027
Add libuuid to pkg-config files
Last modified: 2014-04-25 12:05:23 UTC
Patch coming which fixes statically linking against libgupnp.
Created attachment 258322 [details] [review] build: Add libuuid to Requires.private in the pkg-config files It’s a private dependency, and if it’s not listed here, statically linking against libgupnp will fail with undefined symbol errors for libuuid symbols.
Attachment 258322 [details] pushed as 98dedfe - build: Add libuuid to Requires.private in the pkg-config files
Created attachment 274810 [details] [review] build: Don’t add libuuid to pkg-config files if it’s not a dependency When targeting a build at MinGW, Cygwin or Darwin, libgupnp doesn’t have a dependency on libuuid, so don’t state that it does in the installed pkg-config file.
I didn’t realise the libuuid dependency is optional, so my original patch causes configuration failures on non-Linux platforms when building against libgupnp without libuuid available. This second patch fixes that.
Jens, ping?
Review of attachment 274810 [details] [review]: +1 Sorry
Thanks! :-)
commit 067d43d3debaf09cd37e362f47ba60315b521edc Author: Philip Withnall <philip.withnall@collabora.co.uk> Date: Mon Apr 21 16:20:03 2014 +0100 build: Don’t add libuuid to pkg-config files if it’s not a dependency When targeting a build at MinGW, Cygwin or Darwin, libgupnp doesn’t have a dependency on libuuid, so don’t state that it does in the installed pkg-config file. https://bugzilla.gnome.org/show_bug.cgi?id=711027