After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 711027 - Add libuuid to pkg-config files
Add libuuid to pkg-config files
Status: RESOLVED FIXED
Product: GUPnP
Classification: Other
Component: gupnp
unspecified
Other All
: Normal major
: ---
Assigned To: GUPnP Maintainers
GUPnP Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-10-28 17:29 UTC by Philip Withnall
Modified: 2014-04-25 12:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
build: Add libuuid to Requires.private in the pkg-config files (1.43 KB, patch)
2013-10-28 17:29 UTC, Philip Withnall
committed Details | Review
build: Don’t add libuuid to pkg-config files if it’s not a dependency (2.52 KB, patch)
2014-04-21 15:22 UTC, Philip Withnall
committed Details | Review

Description Philip Withnall 2013-10-28 17:29:14 UTC
Patch coming which fixes statically linking against libgupnp.
Comment 1 Philip Withnall 2013-10-28 17:29:26 UTC
Created attachment 258322 [details] [review]
build: Add libuuid to Requires.private in the pkg-config files

It’s a private dependency, and if it’s not listed here, statically linking
against libgupnp will fail with undefined symbol errors for libuuid symbols.
Comment 2 Jens Georg 2013-11-17 13:19:51 UTC
Attachment 258322 [details] pushed as 98dedfe - build: Add libuuid to Requires.private in the pkg-config files
Comment 3 Philip Withnall 2014-04-21 15:22:34 UTC
Created attachment 274810 [details] [review]
build: Don’t add libuuid to pkg-config files if it’s not a dependency

When targeting a build at MinGW, Cygwin or Darwin, libgupnp doesn’t have
a dependency on libuuid, so don’t state that it does in the installed
pkg-config file.
Comment 4 Philip Withnall 2014-04-21 15:27:46 UTC
I didn’t realise the libuuid dependency is optional, so my original patch causes configuration failures on non-Linux platforms when building against libgupnp without libuuid available. This second patch fixes that.
Comment 5 Philip Withnall 2014-04-25 07:38:21 UTC
Jens, ping?
Comment 6 Jens Georg 2014-04-25 10:24:48 UTC
Review of attachment 274810 [details] [review]:

+1 Sorry
Comment 7 Philip Withnall 2014-04-25 12:04:30 UTC
Thanks! :-)
Comment 8 Philip Withnall 2014-04-25 12:05:05 UTC
commit 067d43d3debaf09cd37e362f47ba60315b521edc
Author: Philip Withnall <philip.withnall@collabora.co.uk>
Date:   Mon Apr 21 16:20:03 2014 +0100

    build: Don’t add libuuid to pkg-config files if it’s not a dependency
    
    When targeting a build at MinGW, Cygwin or Darwin, libgupnp doesn’t have
    a dependency on libuuid, so don’t state that it does in the installed
    pkg-config file.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=711027