After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 710744 - choice name class on attribute not implemented
choice name class on attribute not implemented
Status: RESOLVED FIXED
Product: libxml2
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Daniel Veillard
libxml QA maintainers
Depends on:
Blocks: 760249
 
 
Reported: 2013-10-23 18:45 UTC by Shaun McCance
Modified: 2016-01-07 04:13 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
RNG file to use on both XML test files (411 bytes, application/xml)
2013-10-23 18:46 UTC, Shaun McCance
  Details
XML file that should validate against test.rng (70 bytes, text/xml)
2013-10-23 18:47 UTC, Shaun McCance
  Details
XML file that should not validate against test.rng (114 bytes, text/xml)
2013-10-23 18:47 UTC, Shaun McCance
  Details
Implement choice for attribute name classes (3.42 KB, patch)
2013-10-23 18:53 UTC, Shaun McCance
none Details | Review

Description Shaun McCance 2013-10-23 18:45:04 UTC
If you use a choice as a name class on an attribute, you get the message "Unimplemented block at relaxng.c:9053", and it always matches, even if it shouldn't. You can use choice as a name class on elements without any problems.

Attaching test cases: one RNG file and two XML files. One of the XML files should validate. The other should not. Instead, they both print this warning but still validate. Jing handles these correctly.

I have a patch, which I'll attach once I add regression tests.
Comment 1 Shaun McCance 2013-10-23 18:46:43 UTC
Created attachment 257951 [details]
RNG file to use on both XML test files
Comment 2 Shaun McCance 2013-10-23 18:47:16 UTC
Created attachment 257952 [details]
XML file that should validate against test.rng
Comment 3 Shaun McCance 2013-10-23 18:47:39 UTC
Created attachment 257953 [details]
XML file that should not validate against test.rng
Comment 4 Shaun McCance 2013-10-23 18:53:39 UTC
Created attachment 257956 [details] [review]
Implement choice for attribute name classes
Comment 5 Daniel Veillard 2013-11-28 08:14:35 UTC
Okay, all makes sense :-) Pushed:

https://git.gnome.org/browse/libxml2/commit/?id=6473a41a49601da8355c4b407b99474ada170213

  thanks a lot !

Daniel
Comment 6 David Kilzer 2016-01-07 04:13:46 UTC
(In reply to Daniel Veillard from comment #5)
> Okay, all makes sense :-) Pushed:
> 
> https://git.gnome.org/browse/libxml2/commit/
> ?id=6473a41a49601da8355c4b407b99474ada170213
> 
>   thanks a lot !
> 
> Daniel

This commit missed two test results:

result/relaxng/710744_err
result/relaxng/710744_valid

I filed Bug 760249 to track this fix (patch attached).