After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 710325 - playback: Add subpicture/x-dvb as raw caps
playback: Add subpicture/x-dvb as raw caps
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other All
: Normal normal
: 1.2.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-10-16 20:49 UTC by Thibault Saunier
Modified: 2013-11-09 09:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
playback: Add subpicture/x-dvb as raw caps (690 bytes, patch)
2013-10-16 20:49 UTC, Thibault Saunier
committed Details | Review

Description Thibault Saunier 2013-10-16 20:49:29 UTC
I am not 100% sure what is the reason why we add some caps and not others in there, I just know that in my case I need subpicture/x-dvb to be concidered raw and I can see subpicture/x-dvd in there, so it seems to be right to me.
Comment 1 Thibault Saunier 2013-10-16 20:49:35 UTC
Created attachment 257454 [details] [review]
playback: Add subpicture/x-dvb as raw caps
Comment 2 Edward Hervey 2013-10-17 07:22:19 UTC
If you mean decodebin, you can change the "final" caps via the decodebin "caps" property.
Comment 3 Thibault Saunier 2013-10-17 11:13:05 UTC
I know that, just that the default caps are currently:

     "audio/x-raw; " \
     "text/x-raw; " \
     "subpicture/x-dvd; " \
     "subpicture/x-pgs"

So I though adding

    "subpicture/x-dvb; " \

make sense in that case.
Comment 4 Edward Hervey 2013-10-17 18:56:10 UTC
This is sensible.
Comment 5 Sebastian Dröge (slomo) 2013-10-17 19:35:40 UTC
Yes, definitely
Comment 6 Sebastian Dröge (slomo) 2013-10-17 19:36:16 UTC
Note that in playbin these caps are not used for subtitles, as it's all handled inside subtitleoverlay via magic ;) But for consistency it would be good to get that in
Comment 7 Sebastian Dröge (slomo) 2013-10-30 21:29:01 UTC
commit ddf4ca22033a390fa26c16d717da8e13da3cd567
Author: Thibault Saunier <thibault.saunier@collabora.com>
Date:   Wed Oct 16 16:46:05 2013 -0300

    playback: Add subpicture/x-dvb as raw caps
    
    https://bugzilla.gnome.org/show_bug.cgi?id=710325