GNOME Bugzilla – Bug 710286
the customize page should have 'undo'
Last modified: 2018-01-11 10:06:35 UTC
(from Montreal summit session) There should be an undo or 'back to defaults' button on the customize page.
I would also like to have this. I have a first draft for a patch for this. (Not functional right now, just adds the button which calls an empty lambda.) I think if we have two buttons there now, we should give them an own row. Do we want the reset button trigger some kind of warning before throwing away the settings? I think the most consistent thing would be to provide an undo button like when deleting VMs. Do we want to have it have an own color?
(In reply to comment #1) > I would also like to have this. I have a first draft for a patch for this. (Not > functional right now, just adds the button which calls an empty lambda.) > > I think if we have two buttons there now, we should give them an own row. Where are you placing the buttons? I can't comment on this idea until I know that. :) > Do we want the reset button trigger some kind of warning before throwing away > the settings? I don't think so. I think the most consistent thing would be to provide an undo > button like when deleting VMs. Nope, that is very different. Settings can be changed again to whatever they were before (except for the max disk size). > Do we want to have it have an own color? Once its done, we can show screenshot to designers and see if they want to theme it differently.
Created attachment 275311 [details] Reset button placement example This is how it looks in my current wip branch. If the lambda for the reset function is omitted the reset button will not be shown and everything looks as before. I did not yet manage to implement the reset functionality.
(In reply to comment #3) > Created an attachment (id=275311) [details] > Reset button placement example > > This is how it looks in my current wip branch. If the lambda for the reset > function is omitted the reset button will not be shown and everything looks as > before. I did not yet manage to implement the reset functionality. The button is needed in customize/properties view, not in wizard as we want to have it for existing boxes too.
How good that I posted the proposal. This makes totally sense but I didn't see that. I will make a new proposal.
Created attachment 275474 [details] New Button Placement Example I think this makes sense. Other possibilities would be maybe the topbar or on the bottom right, fixed. But then it might make sense to just apply the reset to the current page.
(In reply to comment #6) > Created an attachment (id=275474) [details] > New Button Placement Example > > I think this makes sense. Other possibilities would be maybe the topbar or on > the bottom right, fixed. But then it might make sense to just apply the reset > to the current page. The button is in the bottom left.
(In reply to comment #6) > Created an attachment (id=275474) [details] > New Button Placement Example > > I think this makes sense. Other possibilities would be maybe the topbar or on > the bottom right, fixed. But then it might make sense to just apply the reset > to the current page. Much better. I showed it to mccann (one of our designers) and he said that 'Reset Settings' sounds like it will reset the settings to some defaults while the button is supposed to just drop current changes. 'Undo' would be the right term here but he also told me consult jimmac so I'll let you know once I ask him. Just that an elongated button with just a small string 'Undo' would look weird IMHO.
(In reply to comment #8) > (In reply to comment #6) > > Created an attachment (id=275474) [details] [details] > > New Button Placement Example > > > > I think this makes sense. Other possibilities would be maybe the topbar or on > > the bottom right, fixed. But then it might make sense to just apply the reset > > to the current page. > > Much better. I showed it to mccann (one of our designers) and he said that > 'Reset Settings' sounds like it will reset the settings to some defaults while > the button is supposed to just drop current changes. 'Undo' would be the right > term here but he also told me consult jimmac so I'll let you know once I ask > him. Just that an elongated button with just a small string 'Undo' would look > weird IMHO. maybe it makes sense to have a back & save and a cancel button which throws away the settings. There was another bug where we thought about users wondering how they could apply the settings. Maybe this would make things clearer there too.
(In reply to comment #9) > (In reply to comment #8) > > (In reply to comment #6) > > > Created an attachment (id=275474) [details] [details] [details] > > > New Button Placement Example > > > > > > I think this makes sense. Other possibilities would be maybe the topbar or on > > > the bottom right, fixed. But then it might make sense to just apply the reset > > > to the current page. > > > > Much better. I showed it to mccann (one of our designers) and he said that > > 'Reset Settings' sounds like it will reset the settings to some defaults while > > the button is supposed to just drop current changes. 'Undo' would be the right > > term here but he also told me consult jimmac so I'll let you know once I ask > > him. Just that an elongated button with just a small string 'Undo' would look > > weird IMHO. > > maybe it makes sense to have a back & save and a cancel button which throws > away the settings. There was another bug where we thought about users wondering > how they could apply the settings. Maybe this would make things clearer there > too. Actually while talking to jimmac, I realized that this bug was more about reverting settings to default values rather than 'undo' of current changes. Most changes are immediate and we shouldn't need an 'undo'. In which case, your design is good. However jimmac said we might want to move the button somewhere else since all other UI in that section (buttom-left) is about runtime stats and actions. 'revert to defaults' doesn't exactly fit in that context. Having said that, I also realized that your initial assertion that its specific to 'box under creation' is correct so sorry about misguiding you there. Since the runtime stats and actions are irrelevant for 'box under construction', I think it makes sense to remove (rather hide) them anyway and therefore we can keep this 'Reset Settings' right where you have put it.
Context: at todays discussion we discussed about relayouting the properties, maybe involving a popover and such funny things. I think it's better to wait with this design decision until we discussed the new properties layout (which probably affects the customize button as well.)
(In reply to comment #11) > Context: at todays discussion we discussed about relayouting the properties, > maybe involving a popover and such funny things. > > I think it's better to wait with this design decision until we discussed the > new properties layout (which probably affects the customize button as well.) I don't agree. The new layout might not even affect this button and even if it does. its not a biggie.
(In reply to Zeeshan Ali (Khattak) from comment #12) > (In reply to comment #11) > > Context: at todays discussion we discussed about relayouting the properties, > > maybe involving a popover and such funny things. > > > > I think it's better to wait with this design decision until we discussed the > > new properties layout (which probably affects the customize button as well.) > > I don't agree. The new layout might not even affect this button and even if > it does. its not a biggie. Well properties are now it's own window, sidebar is gone and we have a separate page for 'Customization' at the wizard's review page. We need to decide where to put the button again. :)
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-boxes/issues/18.