After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 709887 - Impossible to set a fixed TCP port when using MediaDevice subclasses
Impossible to set a fixed TCP port when using MediaDevice subclasses
Status: RESOLVED FIXED
Product: rygel
Classification: Applications
Component: librygel-core
0.20.x
Other Linux
: Normal normal
: ---
Assigned To: rygel-maint
rygel-maint
Depends on:
Blocks:
 
 
Reported: 2013-10-11 08:22 UTC by Jens Georg
Modified: 2013-10-11 09:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
core: Get MediaDevice port from MetaConfig (1.13 KB, patch)
2013-10-11 09:13 UTC, Jens Georg 		none Details | Review
core: Get MediaDevice port from MetaConfig (1.25 KB, patch)
2013-10-11 09:32 UTC, Jens Georg 		committed Details | Review

Description Jens Georg 2013-10-11 08:22:57 UTC 
The code always uses a hard-wired random port, it should use the one from MetaConfig
Comment 1 Jens Georg 2013-10-11 09:13:47 UTC 
Created attachment 256985 [details] [review]
core: Get MediaDevice port from MetaConfig
Comment 2 Jens Georg 2013-10-11 09:15:21 UTC 
This might get interesting when you try to use a renderer and a server in the same process :-/
Comment 3 Krzesimir Nowak 2013-10-11 09:23:22 UTC 
Review of attachment 256985 [details] [review]:

Just a nit.

::: src/librygel-core/rygel-media-device.vala
@@ +68,1 @@
         this.manager = ContextManager.create (0);

Just quickly point out that you want to pass the port variable to ContextManager.create too.
Comment 4 Jens Georg 2013-10-11 09:28:51 UTC 
Details... ;) Thanks!
Comment 5 Jens Georg 2013-10-11 09:32:18 UTC 
Created attachment 256986 [details] [review]
core: Get MediaDevice port from MetaConfig
Comment 6 Jens Georg 2013-10-11 09:44:14 UTC 
Attachment 256986 [details] pushed as 910318f - core: Get MediaDevice port from MetaConfig